From: Pavel Machek <pavel@ucw.cz>
To: Heiko Stuebner <heiko@sntech.de>
Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: Document "rc-feedback" trigger
Date: Mon, 7 Oct 2024 20:01:27 +0200 [thread overview]
Message-ID: <ZwQh99TjfKhoP6UK@duo.ucw.cz> (raw)
In-Reply-To: <20241007160804.2447947-1-heiko@sntech.de>
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
On Mon 2024-10-07 18:08:04, Heiko Stuebner wrote:
> Document the "rc-feedback" trigger which is used to control LEDs by
> remote control device activity. This is an existing trigger used in
> existing DTs, document it so validation of those DTs would pass.
>
> It was originally introduced into the Linux kernel in 2013 with
> commit 153a60bb0fac ("[media] rc: add feedback led trigger for rc keypresses")
> index bf9a101e4d42..32f9116e03a2 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -119,6 +119,8 @@ properties:
> # if trigger is absent
> - none
> # LED indicates camera torch state
> + - rc-feedback
> + # LED indicates remote control feedback
> - torch
> # LED indicates USB gadget activity
> - usb-gadget
NAK. Wrongly placed comment.
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2024-10-07 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 16:08 [PATCH] dt-bindings: leds: Document "rc-feedback" trigger Heiko Stuebner
2024-10-07 18:01 ` Pavel Machek [this message]
2024-10-07 20:52 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwQh99TjfKhoP6UK@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox