From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 258C1194A40; Fri, 11 Oct 2024 15:23:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.255.230.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728660213; cv=none; b=aMa+/tCjVZYRhZ1eAMW3OtPwHXfyFU3iI93l0WCBucQgawVSH2ERNUPzvqtVXN8JstDxYIpG05SYbhbLtqeKkK3BH4x/IaveUXiiDvxjqfEl5liLMc6PkVR58JBNd9OJCyLYUyGtJDiWim3QVcBLOKRSRHnIlmjFFGuQPYF0W1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728660213; c=relaxed/simple; bh=dNkSK16lr1JQGU/ueH8/BjMoCQlHXeuOs4ScHbna40o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t74GWS1vidXAkpPpBKT4iykxKUnq7V8xzNKFdofj7hbS5fahiCtbu9aChFDp7MjyrzwLK780YAqXhGeEfKDLk1E3jwMObSUL/crxvi6krj6f/5DWo42Qauk4u3j4IsqJfm2jLvov8WWjiTSVqrO/ELNPJx/qI7PLcbF5Ij9lkJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ucw.cz; spf=pass smtp.mailfrom=ucw.cz; dkim=pass (1024-bit key) header.d=ucw.cz header.i=@ucw.cz header.b=BkKdV6cv; arc=none smtp.client-ip=46.255.230.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ucw.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ucw.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ucw.cz header.i=@ucw.cz header.b="BkKdV6cv" Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id EDC561C0087; Fri, 11 Oct 2024 17:23:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1728660207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x+uzJgAZKr0aQskZeYDshW8VRu9nH9afBqYYtu8uge4=; b=BkKdV6cvGSL2VVmCHgZHtvvMduAME43++YaCcGI1vW5aZhaCeH6rvzvpMZqanlABN0qGdI TO5Eg6T+zPnoGSqe/eJ8Bi7AJD0AEsSm35xVOJKXHZPIxCKrIwOo9+ay2dty13XTksXixY NdtBHZ5k9mYh3L9toHtex9VzwQHBipo= Date: Fri, 11 Oct 2024 17:23:27 +0200 From: Pavel Machek To: Benjamin Tissoires Cc: Werner Sembach , Armin Wolf , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , dri-devel@lists.freedesktop.org, jelle@vdwaa.nl, jikos@kernel.org, lee@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, miguel.ojeda.sandonis@gmail.com, ojeda@kernel.org, onitake@gmail.com, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices Message-ID: References: <84b629c6-5b26-4285-9b2f-66dd1afa99e5@tuxedocomputers.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2TcMguCtEoo8TZyh" Content-Disposition: inline In-Reply-To: --2TcMguCtEoo8TZyh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > There is a slight difference between mouse support and LEDs on your > > > keyboard. The former is actually required to bring up the machine and= to > > > use it, the latter is nice to have. > >=20 > > But that's not the difference that matters. Linux is not microkernel, > > and is trying to provide hardware abstractions. (Except for printers, > > I guess that's because printers are often network devices). > >=20 > > Besides, mouse was not required to bring up a machine "back then". > >=20 > > Besides, > >=20 > > 1) using those keyboards in dark room without backlight is hard, > > because their labels are translucent and not having enough contrast. > >=20 > > 2) rainbow effects make people ill. >=20 > And I agree with you here. And that's also why I agree with Werner's > plan: have a minimum support in kernel for that with the already > supported LED class, which is supported by UPower and others, and let > the ones who want the fancy effects be in charge of their mess. But the patch being proposed does not match the this description, right? And for hardware I seen, "minimum driver" you describe would be already 90% of the full driver. (We can just use fbdev interface...) Anyway, lets do it. I have rgb keyboard, you have few, and we have Tuxedocomputers with machines where driver can't live in userspace. If you have working driver, lets see it. I have posted my copy, but I hae problem where keyboard functionality stops working when its loaded. Can you help? Then we can see how much of the driver is required for basic functionality. I suspect it will be fairly easy to turn it into "full" driver at that point. > > Note how we have drivers for audio, LEDs, cameras, dunno, iio sensors, > > none of that is required to bring system up. > >=20 > > We need driver for the WMI stuff in kernel. And that point it should > > be pretty clear proper driver/subsystem should be done. >=20 > Yes, and again, I never said we need to provide WMI to userspace. Good. > What I want is: > - provide a minimum support on Linux using already existing APIs (LED > class) > - allow crazy people to do their thing if they want to have a rainbow > initiated by every key press > - ensure the minimum support of the LED class is not messed up when > people start using the HID LampArray API. >=20 > HID LampArray is a ratified standard by a few hardware makers already[0] > (Acer, Asus, HP, Logitech, Razer, SteelSeries and Twinkly apparently). I have yet to see HID LampArray device. Best regards, Pavel --=20 People of Russia, stop Putin before his war on Ukraine escalates. --2TcMguCtEoo8TZyh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZwlC7wAKCRAw5/Bqldv6 8qY2AKC+nAvGhkJI328sv8/1wPlLQa94/ACfdypXrZPZo6fWin1NoeaTgtYi2cc= =98+x -----END PGP SIGNATURE----- --2TcMguCtEoo8TZyh--