From: Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk>
To: michal.vokac@ysoft.com, pavel@ucw.cz, lee@kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
krzk+dt@kernel.org
Subject: Re: [PATCH v4 2/3] leds: Add LED1202 I2C driver
Date: Tue, 5 Nov 2024 06:23:20 +0100 [thread overview]
Message-ID: <ZymryKmQxU6Ndkih@admins-Air> (raw)
In-Reply-To: <01b7029f-ecac-4b45-a28d-04081b326024@ysoft.com>
>
> Hi Vicentiu,
Hey Michal
> Once a while I browse through the patches in various mailing lists to keep myself informed.
> So I came across your patch set pretty randomly.
>
> I have few tips for you to make your life easier before you get to some serious troubles
> with the maintainers ;)
>
Thanks for the advice. Annoying the maintainers was definitely not my intention.
My apologies for any inconvenience.
> 1. Always send all the patches in the series to the same recipients list.
>
> That is, do not send dt-bindings to just Rob, Krzysztof etc. and LED driver
> patches to Lee et al. We all need to see the whole thing.
>
> If you run the scripts/get_maintainer.pl script on the series, you get a complete list.
> This is what Krzysztof requested you to do in his comments to v3.
Ok. Understood
> 2. Use git format-patch and git send-email tools to submit patches.
>
> If you use these tools you will avoid issues with wrong threading of the messages.
>
I have a Macbook as a work computer.
I've found online that the way to send it on Mac is with mutt.
Most certanly I lack some skills, but I took me almost 1 day to have everything working
mutt + google account + script mutt_oauth2.py
So, quickly jumping to git format-patch and git send-email was something I was not looking
forward to.
> 3. The following text should not be here.
>
> You are supposed to just reply in-place to the review messages to acknowledge
> that you read the comments and you understand what the reviewers want to
> change. Then you send a next version of the series as a new message to all
> the recipients. Definitely not as a in-reply-to to the previous version.
>
Ok. I think I got. Hopefully the next ones will be ok.
>
> Best regards,
> Michal
Thanks again and best regards,
Vicentiu
prev parent reply other threads:[~2024-11-05 5:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 14:47 [PATCH v4 2/3] leds: Add LED1202 I2C driver Vicentiu Galanopulo
2024-11-01 17:06 ` Lee Jones
2024-11-02 11:16 ` Vicentiu Galanopulo
2024-11-04 15:16 ` Michal Vokáč
2024-11-05 5:23 ` Vicentiu Galanopulo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZymryKmQxU6Ndkih@admins-Air \
--to=vicentiu.galanopulo@remote-tech.co.uk \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=michal.vokac@ysoft.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox