From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FF9AC32771 for ; Fri, 19 Aug 2022 09:09:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347773AbiHSJJG (ORCPT ); Fri, 19 Aug 2022 05:09:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347477AbiHSJJE (ORCPT ); Fri, 19 Aug 2022 05:09:04 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C46DC875E for ; Fri, 19 Aug 2022 02:09:03 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id z6so5319184lfu.9 for ; Fri, 19 Aug 2022 02:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=QZ60a7njs7IG948rZhCyRtft/iD3ZUBC7eYaZRnpLFA=; b=cfh92PDUUzDErD7ZwgSsE0YtwFh3ZrinlQcS1hojt2pG3zo2s6UVJkCSaB6ATTDaOQ hKITedK53sbmXsZlkhLkRXypNlI0O1EsJquweKp8Yndl6Aw1pbOlNy6KnlN+VJ/PLOXa QM0LEHj1uEH1K5Quegx/GYhWAgvTEVBpSrKS6KjQcObiu3YZ96I0nFx5g1SY/jJ6rPJ/ dZAP+2sFfSd+zLFPCEvw1koFJaac7MDzrmLvgUehtE+fIw+RIKHagW2+IqTboLaexASJ i9iyInOAvdb8SJLR6XcdUOSjt1kjwziI7Y+NEqr20Dquew2n+XAZHQjUKhrQmgv/pDfU BZbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=QZ60a7njs7IG948rZhCyRtft/iD3ZUBC7eYaZRnpLFA=; b=8Q5Jq3Auj2tUMWQjgR2T3fCOZRlJsEqblerLXaOIO6IwOQYrpUqVz1dScN25eOoPTa jYRSxtNDGOGctXEZVBhqBkaBwYAK0uezE2uHK55CzpL571SRfZFth/cdXgodax06/3iK +oUmrxUkpQPa92XPSIhRrWoxwmByJD/MJy66V1hkkN8PB56s6f0i1vrA3m17us6Ts3CR IZz3Y9u5dXJYVdTJh90DKkeJIf6tAhYBwMvK2gdu1UbubHf9jU4ck/VVUDqo8A5Psco6 qnfmOxLC+gWmtouDt2RSfITbVSB5M4cZw7Yq6iBTK5lTslxUYwuq0+7/JsU4Yka2hq9L NnUw== X-Gm-Message-State: ACgBeo1aRBhI73NetSYMH7EpWPUh6tOUWT7gzVr+s/k9LG+yLC7NIFrK tE8ZW9u+RtFB07JNBAGEI00Ddw== X-Google-Smtp-Source: AA6agR5ER+81K7w1ZtEXKG6dSNHxMZH8A9tQWAmUjpRddEe+flGhry+JKR6M3TDID4l3BuKm6j1kmA== X-Received: by 2002:a05:6512:2389:b0:492:ba6a:ef43 with SMTP id c9-20020a056512238900b00492ba6aef43mr2318997lfv.394.1660900141694; Fri, 19 Aug 2022 02:09:01 -0700 (PDT) Received: from ?IPV6:2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5? (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id a27-20020ac25e7b000000b00489e38c4fc4sm559192lfr.276.2022.08.19.02.09.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Aug 2022 02:09:01 -0700 (PDT) Message-ID: Date: Fri, 19 Aug 2022 12:08:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/2] dt-bindings: leds: register-bit-led: Add active-low property Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: Pavel Machek , Rob Herring , Krzysztof Kozlowski , Linus Walleij , =?UTF-8?Q?Marek_Beh=c3=ban?= , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220818172528.23062-1-pali@kernel.org> <20220819065620.wvmy3kigvvbwo4bo@pali> <20220819080814.GA6653@duo.ucw.cz> <20220819084222.ru4olyfntunlm3f3@pali> From: Krzysztof Kozlowski In-Reply-To: <20220819084222.ru4olyfntunlm3f3@pali> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 19/08/2022 11:42, Pali Rohár wrote: > On Friday 19 August 2022 11:38:29 Krzysztof Kozlowski wrote: >> On 19/08/2022 11:08, Pavel Machek wrote: >>> Hi! >>> >>>>> Although the question is - where is the user of it? >>>> >>>> I was planning to send updated powerpc DTS files with these >>>> register-bit-led definitions after accepting dt bindings. >>> >>> We need device tree people to ack them, first. But a note saying "this >>> is for Turris Omnia router" would be welcome. >> >> In general the process is one of: >> 1. Send DT bindings with driver and DTS changes, >> 2. Send DT bindings with driver in one patchset, DTS in second but you >> mention the dependency. >> >> You should not wait with DTS till bindings got accepted. Why? Because >> for example we do not want bindings for stuff which never is going to be >> upstreamed (with several exceptions, e.g. for other systems). Also >> because we want to be able to compare bindings with your DTS >> implementing them, so we are sure you described everything (especially >> that you said running one command to install dtchema and second command >> to make the check is not possible in your system). >> >> Without DTS here how can anyone be sure your DTS actually follows the >> bindings? >> >> Best regards, >> Krzysztof > > Well, last time I was told that first needs to be accepted bindings > documentation and then device tree files. So I did it like this. And now > it is again feasible and different steps and ordering is needed... > Sorry I cannot known all requirements which are moreover changing every > day. The rule is the same from years and no one was changing it. All driver submitters, all DTS developers follow this. You are literally the one of very few which is surprised by that generic rule and call it "a change". The patches should be accepted by maintainers in such order (so without bindings acceptance, the driver and DTS should not go), but not the sending order. It's the same with sysfs ABI. Exactly the same. Best regards, Krzysztof