From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org
Subject: Re: Cleanups in "next" tree
Date: Fri, 3 Apr 2020 20:45:16 +0200 [thread overview]
Message-ID: <a4802e70-106b-3476-536f-1d8798ce156f@gmail.com> (raw)
In-Reply-To: <20200402225745.GA9830@amd>
On 4/3/20 12:57 AM, Pavel Machek wrote:
> On Sun 2020-03-22 14:35:56, Jacek Anaszewski wrote:
>> Hi Pavel,
>>
>> On 3/22/20 12:59 PM, Pavel Machek wrote:
>>> Hi!
>>>
>>> I've commited some cleanups into LED tree ( git/pavel/linux-leds.git
>>> branch for-next ), if someone wants to review them.
>>
>> You abused your maintainer power by bypassing the usual patch
>> submission procedure. Please remove the patches from linux-next
>> and submit them officially for discussion. I would have some objections
>> to them.
>
> I'm sorry I failed to meet your high expectations... But I don't
> believe I done anything completely outside of usual kernel procedures.
I believe code review is quite usual kernel procedure.
> Could you list the patches and objections you have?
I already expressed my concerns regarding Turris Omnia patch.
My comments regarding remaining patches:
- "Make label "white:power" to be consistent with"
I disagree here. "system" was OK.
- "Warn about old defines that probably should not be used."
Obsolete is only LED_FULL, so the comment is in wrong line
- "Group LED functions according to functionality, and add some"
You're adding here some random comments referencing obsolete
naming. I think that it is enough to say what is current standard.
Also, I had a patch [0] describing standard LED functions in my LED
naming patch set, but it was not merged. It could be worth getting
back to it at this occasion.
[0]
https://lore.kernel.org/linux-leds/20190609190803.14815-27-jacek.anaszewski@gmail.com/
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2020-04-03 18:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 11:59 Cleanups in "next" tree Pavel Machek
2020-03-22 13:35 ` Jacek Anaszewski
2020-03-22 15:05 ` Dan Murphy
2020-04-02 22:57 ` Pavel Machek
2020-04-03 12:49 ` Dan Murphy
2020-04-03 18:45 ` Jacek Anaszewski [this message]
2020-04-03 19:07 ` Dan Murphy
2020-04-07 7:28 ` Pavel Machek
2020-04-07 20:23 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4802e70-106b-3476-536f-1d8798ce156f@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).