Re: [PATCH] leds: rgb: leds-ktd202x: Fix error code in ktd202x_setup_led_rgb()

[Dan Carpenter <dan.carpenter@linaro.org>]

On Tue, Dec 09, 2025 at 04:14:03PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 9, 2025 at 8:56 AM Dan Carpenter <dan.carpenter@linaro.org> wrote:
> >
> > Return -EINVAL if the "reg" value is invalid.  This is unlikely to
> > happen in real life because it comes from the firmware, whether from
> > device tree or ACPI.
> 
> ...
> 
> >                 if (ret != 0 || reg >= chip->num_leds) {
> >                         dev_err(chip->dev, "invalid 'reg' of %pfw\n", child);
> >                         fwnode_handle_put(child);
> > -                       return ret;
> > +                       return ret ?: -EINVAL;
> >                 }
> 
> I think the better fix is to split the original conditional to two.
> 
> And make the message something like
> "can't retrieve 'reg' property of %pfw\n'
> for the case if (ret).
> 

These are never going to show up for users, the messages are only for
developers bringing up a board...

regards,
dan carpenter