From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 429DA34B663 for ; Fri, 6 Mar 2026 15:11:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772809903; cv=none; b=i7h42YFpwoY0bNu4PoVNJZ1u7ffYUPgLJ5LeKvCqYdzvLONaAVf586T6oLallFTVa09KrpB5aEd4Hebhe3kSG4zZbBcyqaTYd2yjJTRuoPCNNA1qCxH11p/5dLcrvoxq3i0pMyf72pf7grCF9Me9TT0WtiOEiQgfPDcjh7IWw74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772809903; c=relaxed/simple; bh=lWj8J0pEAC+qw3u635QWARXfLuV65lUsAXrV96+FMMY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YZ5w1fSa2fyfz/1OW5avNax4zDdSTtoiPZfE7W3sudry+W8QpKJanq/Ys9fuf72yBY55VNSgS+ZYKKrcAusaReWfiWVqBi+hP6He0DWhUVr70AauAYSUao5pEm7/56hNFwJgvM+p1T1Zfrv7OsULcpJA/pg9rEHJc64I1I/LAwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cE8JC8nz; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cE8JC8nz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772809902; x=1804345902; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lWj8J0pEAC+qw3u635QWARXfLuV65lUsAXrV96+FMMY=; b=cE8JC8nzltuQzqUi/LxZ/J/LWVEABHjBhMytOZKUG7XJqcicTUXRtI/v i+YeoSHfKqEqYugwvZBVp8s8Pp4VGClAx3aMSEomnKjEzntKHdWH2bXDh WkS3xvxjQBR9V6PyD8OwQ7snQLqxm5WvygH27MOleGuPOEKJ1heZ8DM/J HRGf6kZWjrECrfIIaDe2kFWPBs1n/TbjiqrtEo/6lXOtTolN9HZ1y61qZ HcqzSCBSqsQxXU7m0EiPdvDiR+iDW021ceHvRCHRa3Gqe5qTRTl9/yb0C yG8wHI2J72GddRM8GcOhymZcMvdM5EX5QN3zqUeEgLQnMy2xrdHBJr5jt w==; X-CSE-ConnectionGUID: InK0rgffTSyHZDolFEoo1Q== X-CSE-MsgGUID: ff0TnBHJT/OHK7uUGJ0S+Q== X-IronPort-AV: E=McAfee;i="6800,10657,11721"; a="73794781" X-IronPort-AV: E=Sophos;i="6.23,105,1770624000"; d="scan'208";a="73794781" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2026 07:11:39 -0800 X-CSE-ConnectionGUID: fzLMhTrsSmqjo+tLBzVA/g== X-CSE-MsgGUID: aDgyt5NeTOGVdZQaaS7LAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,105,1770624000"; d="scan'208";a="223520314" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.1]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2026 07:11:37 -0800 Date: Fri, 6 Mar 2026 17:11:34 +0200 From: Andy Shevchenko To: Lee Jones Cc: Michael Tretter , Pavel Machek , linux-leds@vger.kernel.org, kernel@pengutronix.de, Thorsten Schmelzer Subject: Re: [PATCH] leds: led-class: detect brightness conversion base from string Message-ID: References: <20260123-leds-class-convert-brightness-value-v1-1-ae9d3ae4224b@pengutronix.de> <20260306113221.GI183676@google.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260306113221.GI183676@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Fri, Mar 06, 2026 at 11:32:21AM +0000, Lee Jones wrote: > On Thu, 05 Mar 2026, Andy Shevchenko wrote: > > On Fri, Jan 23, 2026 at 10:57:26AM +0100, Michael Tretter wrote: > > > From: Thorsten Schmelzer > > > > > > sysfs-class-led doesn't specify the number format for the brightness, > > > but the class only accepts base 10 numbers. > > > > > > Use the automatic base detection of kstrtoul and accept the brightness > > > as hex value as well. > > > > This obviously brings a regression. > > Previously the 000000000000100 is 100, now it's 64. > > > > While I don't care much (I even like the change), I have to point this out. > > > > The correct fix is to update documentation. > > Again, should we remove this patch that you like? Depends if anybody outside relies on the above mentioned decimal values with leading 0(s). On the safest side is better to drop (and explain in the documentation that the values are decimal). -- With Best Regards, Andy Shevchenko