From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
drivshin.allworx@gmail.com
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pyra-handheld.com, marek@goldelico.com,
letux-kernel@openphoenux.org,
Andrey Utkin <andrey_utkin@fastmail.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: [PATCH v2 2/2] led: is31fl32xx: define complete i2c_device_id table
Date: Mon, 18 Jul 2016 19:03:31 +0200 [thread overview]
Message-ID: <ac126ab8d93d45ae5b001a7b51a893c2380315bf.1468861410.git.hns@goldelico.com> (raw)
In-Reply-To: <cover.1468861410.git.hns@goldelico.com>
In-Reply-To: <cover.1468861410.git.hns@goldelico.com>
Otherwise the driver module will not be automatically probed.
Fixes: 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family
of LED controllers")
Fixes: e0442d7def8f ("leds: Add SN3218 and SN3216 support to the
IS31FL32XX driver")
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Tested-by: David Rivshin <drivshin@allworx.com>
Acked-by: David Rivshin <drivshin@allworx.com>
---
drivers/leds/leds-is31fl32xx.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c
index a53b71e..478844c 100644
--- a/drivers/leds/leds-is31fl32xx.c
+++ b/drivers/leds/leds-is31fl32xx.c
@@ -482,10 +482,16 @@ static int is31fl32xx_remove(struct i2c_client *client)
}
/*
- * i2c-core requires that id_table be non-NULL, even though
- * it is not used for DeviceTree based instantiation.
+ * i2c-core (and modalias) requires that id_table be properly filled,
+ * even though it is not used for DeviceTree based instantiation.
*/
static const struct i2c_device_id is31fl32xx_id[] = {
+ { "is31fl3236" },
+ { "is31fl3235" },
+ { "is31fl3218" },
+ { "sn3218" },
+ { "is31fl3216" },
+ { "sn3216" },
{},
};
--
2.7.3
next prev parent reply other threads:[~2016-07-18 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 17:03 [PATCH v2 0/2] led: is31fl32xx: minor improvements H. Nikolaus Schaller
2016-07-18 17:03 ` [PATCH v2 1/2] led: is31fl32xx: fix typo in id and match table names H. Nikolaus Schaller
2016-07-18 17:03 ` H. Nikolaus Schaller [this message]
2016-07-19 6:59 ` [PATCH v2 0/2] led: is31fl32xx: minor improvements Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac126ab8d93d45ae5b001a7b51a893c2380315bf.1468861410.git.hns@goldelico.com \
--to=hns@goldelico.com \
--cc=andrey_utkin@fastmail.com \
--cc=drivshin.allworx@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=j.anaszewski@samsung.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek@goldelico.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).