From: Dan Murphy <dmurphy@ti.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
pavel@ucw.cz, robh@kernel.org
Subject: Re: [PATCH v3 14/25] dt-bindings: lm36010: Add function and color properties
Date: Fri, 5 Apr 2019 06:48:44 -0500 [thread overview]
Message-ID: <adf1f4fe-6a23-4244-db71-b5c3dbcf9615@ti.com> (raw)
In-Reply-To: <20190331175501.23471-15-jacek.anaszewski@gmail.com>
Jacek
On 3/31/19 12:54 PM, Jacek Anaszewski wrote:
> Refer to new "function" and "color" properties and mark "label"
> as deprecated.
>
> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Dan Murphy <dmurphy@ti.com>
> ---
> Documentation/devicetree/bindings/leds/leds-lm3601x.txt | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> index a88b2c41e75b..095dafb6ec7f 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> @@ -22,9 +22,14 @@ Required properties for flash LED child nodes:
> - led-max-microamp : Range from 2.4mA - 376mA
>
> Optional child properties:
> - - label : see Documentation/devicetree/bindings/leds/common.txt
> + - function : see Documentation/devicetree/bindings/leds/common.txt
> + - color : see Documentation/devicetree/bindings/leds/common.txt
> + - label : see Documentation/devicetree/bindings/leds/common.txt (deprecated)
>
> Example:
> +
> +#include <dt-bindings/leds/common.h>
> +
> led-controller@64 {
> compatible = "ti,lm36010";
> #address-cells = <1>;
> @@ -33,7 +38,8 @@ led-controller@64 {
>
> led@0 {
> reg = <1>;
> - label = "white:torch";
> + function = LED_FUNCTION_TORCH;
> + color = <LED_COLOR_ID_WHITE>;
> led-max-microamp = <376000>;
> flash-max-microamp = <1500000>;
> flash-max-timeout-us = <1600000>;
>
Reviewed-by: Dan Murphy <dmurphy@ti.com>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2019-04-05 11:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 17:54 [PATCH v3 00/25] Add generic support for composing LED class device name Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 01/25] leds: class: Improve LED and LED flash class registration API Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 02/25] dt-bindings: leds: Add LED_FUNCTION definitions Jacek Anaszewski
2019-04-05 1:11 ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 03/25] dt-bindings: leds: Add LED_COLOR_ID definitions Jacek Anaszewski
2019-04-05 1:12 ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 04/25] dt-bindings: leds: Add function, color and led-enumerator properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 05/25] leds: core: Add support for composing LED class device names Jacek Anaszewski
2019-04-05 11:45 ` Dan Murphy
2019-04-05 20:08 ` Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 06/25] dt-bindings: sc27xx-blt: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 07/25] leds: sc27xx-blt: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 08/25] dt-bindings: lt3593: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 09/25] leds: lt3593: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 10/25] dt-bindings: lp8860: Add function and color properties Jacek Anaszewski
2019-04-05 11:47 ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 11/25] leds: lp8860: Use generic support for composing LED names Jacek Anaszewski
2019-04-11 15:28 ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 12/25] dt-bindings: lm3692x: Add function and color properties Jacek Anaszewski
2019-04-05 11:48 ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 13/25] leds: lm3692x: Use generic support for composing LED names Jacek Anaszewski
2019-04-11 15:29 ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 14/25] dt-bindings: lm36010: Add function and color properties Jacek Anaszewski
2019-04-05 11:48 ` Dan Murphy [this message]
2019-03-31 17:54 ` [PATCH v3 15/25] leds: lm3601x: Use generic support for composing LED names Jacek Anaszewski
2019-04-11 15:29 ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 16/25] dt-bindings: cr0014114: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 17/25] leds: cr0014114: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 18/25] dt-bindings: aat1290: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 19/25] leds: aat1290: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 20/25] dt-bindings: as3645a: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 21/25] leds: as3645a: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 22/25] dt-bindings: leds-gpio: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 23/25] leds: gpio: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:55 ` [PATCH v3 24/25] dt-bindings: an30259a: Add function and color properties Jacek Anaszewski
2019-03-31 17:55 ` [PATCH v3 25/25] leds: an30259a: Use generic support for composing LED names Jacek Anaszewski
2019-04-04 13:21 ` [PATCH v3 00/25] Add generic support for composing LED class device name Pavel Machek
2019-04-04 19:18 ` Jacek Anaszewski
2019-04-06 9:46 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adf1f4fe-6a23-4244-db71-b5c3dbcf9615@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).