From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Conor Dooley <conor@kernel.org>
Cc: Svyatoslav Ryhel <clamor95@gmail.com>, Lee Jones <lee@kernel.org>,
Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: leds: Document TI LM3560 Synchronous Boost Flash Driver
Date: Mon, 20 Apr 2026 19:38:25 +0300 [thread overview]
Message-ID: <aeZWgcARBqMQatrr@kekkonen.localdomain> (raw)
In-Reply-To: <20260420-affection-ferocious-e28cd29f360a@spud>
Hi Conor,
On Mon, Apr 20, 2026 at 05:20:28PM +0100, Conor Dooley wrote:
> > +properties:
> > + compatible:
> > + enum:
> > + - ti,lm3559
> > + - ti,lm3560
>
> What differentiates these devices to the point that fallback compatibles
> are not suitable?
Good question.
It seems the currents are different albeit the register values themselves
are the same. The driver doesn't seem to handle that properly right now, so
it's a driver bug.
I'd keep the compatibles as-is as the current limit applied should be as
specified in DT.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2026-04-20 16:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 9:34 [PATCH v2 0/5] media: lm3560: convert to use OF bindings Svyatoslav Ryhel
2026-04-19 9:34 ` [PATCH v2 1/5] dt-bindings: leds: Document TI LM3560 Synchronous Boost Flash Driver Svyatoslav Ryhel
2026-04-20 16:20 ` Conor Dooley
2026-04-20 16:35 ` Svyatoslav Ryhel
2026-04-20 16:38 ` Sakari Ailus [this message]
2026-04-19 9:34 ` [PATCH v2 2/5] media: i2c: lm3560: Fix v4l2 subdev registration Svyatoslav Ryhel
2026-04-19 9:34 ` [PATCH v2 3/5] media: i2c: lm3560: Optimize mutex lock usage Svyatoslav Ryhel
2026-04-19 9:34 ` [PATCH v2 4/5] media: i2c: lm3560: Convert to use OF bindings Svyatoslav Ryhel
2026-04-19 9:34 ` [PATCH v2 5/5] media: i2c: lm3560: Add support for PM features Svyatoslav Ryhel
2026-04-21 16:44 ` Sakari Ailus
2026-04-21 17:32 ` Svyatoslav Ryhel
2026-04-21 19:59 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeZWgcARBqMQatrr@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox