From: Pavel Machek <pavel@ucw.cz>
To: Lee Jones <lee@kernel.org>
Cc: Lorenzo Egidio <lorenzoegidioms@gmail.com>, linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: tests: clarify name conflict test It is a good practice to use a fresh led_classdev instance when doing the testing. LED_REJECT_NAME_CONFLICT rather than re-registering the already registered LED class device. Besides that, do a zero initialization of led_lookup_data.
Date: Fri, 12 Jun 2026 12:32:55 +0200 [thread overview]
Message-ID: <aivgV_T8QCVXs29-@ucw.cz> (raw)
In-Reply-To: <20260612084519.GE1212816@google.com>
> /* Sashiko Automation: Reviewed (0 Findings) */
If Sashinko can't see problem with this, Sashiko needs to be fixed.
> > > Signed-off-by: Lorenzo Egidio <lorenzoegidioms@gmail.com>
> > > ---
> > > drivers/leds/led-test.c | 102 ++++++++++++++++++++++++++--------------
> > > 1 file changed, 66 insertions(+), 36 deletions(-)
> >
> > NAK.
>
> Definitely, but can you give the contributor something to work on?
Do we put entire changelog in a message subject? No.
BR,
Pavel
prev parent reply other threads:[~2026-06-12 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 17:21 [PATCH] leds: tests: clarify name conflict test It is a good practice to use a fresh led_classdev instance when doing the testing. LED_REJECT_NAME_CONFLICT rather than re-registering the already registered LED class device. Besides that, do a zero initialization of led_lookup_data Lorenzo Egidio
2026-06-10 23:04 ` Pavel Machek
2026-06-12 8:45 ` Lee Jones
2026-06-12 10:32 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aivgV_T8QCVXs29-@ucw.cz \
--to=pavel@ucw.cz \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lorenzoegidioms@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox