From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 792223438B4; Fri, 12 Jun 2026 20:16:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781295387; cv=none; b=V9/E3F6FF/F+gzgYQEdVn9EQ7MpgvYiqI142Gjx73SC46ErvOTPS+IwZLloJAZV/9BgtnFkKxdnG6sqklFjtSS62sFiQYIxplNJCC6eC14FLfp4sf3xoXPD9qfaxs5pS8eSu0UcEJmQAheEdrnjENPknfTE5G/QoaQpkMC8OSO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781295387; c=relaxed/simple; bh=D39oCbI6GnTZppIvDAl9pgGpJpOY19zw9047pMIJRo0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iPIH9ypq9MODXy5Mem9MfNU5uPbnCMsbv54PhySWZHTCZwSZlHjiZjcdkmZRUTT0TXoDYq8WvyN1n33R0eCniGKrWY5RtONxat3vVHN12d0+iGeYT6kqr44vGttpcNfo5Yh2ZDwH17+6dsgk+xW6v/xRapFE2jfH3blwcZN0vLc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=timmermann.space; spf=pass smtp.mailfrom=timmermann.space; arc=none smtp.client-ip=80.241.56.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=timmermann.space Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=timmermann.space Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4gcW4F44bJz9tPs; Fri, 12 Jun 2026 22:16:13 +0200 (CEST) Date: Fri, 12 Jun 2026 22:16:10 +0200 From: Lukas Timmermann To: Ethan Nelson-Moore , Lee Jones , linux-leds@vger.kernel.org Cc: stable@vger.kernel.org, Pavel Machek Subject: Re: [PATCH] leds: as3668: correct name of config option to match Makefile Message-ID: References: <20260610224244.128063-1-enelsonmoore@gmail.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260610224244.128063-1-enelsonmoore@gmail.com> On Wed, Jun 10, 2026 at 03:42:43PM -0700, Ethan Nelson-Moore wrote: > The Makefile for the AS3668 LED driver refers to CONFIG_LEDS_AS3668, > whereas the config file defines CONFIG_LEDS_OSRAM_AMS_AS3668. This > causes the driver to never be compiled. Correct the name in the Kconfig > file to match the Makefile. Doing the opposite would also have worked, > but the name in the Makefile better matches the format of other > drivers' options. > > Fixes: c7dd343a3756 ("leds: as3668: Driver for the ams Osram 4-channel i2c LED driver") > Cc: stable@vger.kernel.org # 7.0+ > Signed-off-by: Ethan Nelson-Moore > --- > drivers/leds/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > index f4a0a3c8c870..5ac63cb59469 100644 > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -107,7 +107,7 @@ config LEDS_ARIEL > > Say Y to if your machine is a Dell Wyse 3020 thin client. > > -config LEDS_OSRAM_AMS_AS3668 > +config LEDS_AS3668 > tristate "LED support for Osram AMS AS3668" > depends on LEDS_CLASS > depends on I2C > -- > 2.43.0 > > Hi Ethan, thank you for noticing that issue. This was already fixed here: https://lore.kernel.org/all/177815964265.1857555.230971455145782585.b4-ty@b4/ Best regards Lukas