From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] leds: pca9532: fix device_node_continue.cocci warnings
Date: Thu, 29 Dec 2016 22:39:54 +0100 (CET)
Message-ID: <alpine.DEB.2.20.1612292238300.2245@hadrien>
References: <alpine.DEB.2.20.1612292207390.2245@hadrien> <963119a2-efe4-86ef-16a8-85e5f4487b66@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-leds-owner@vger.kernel.org>
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:16186
        "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751112AbcL2Vj5 (ORCPT
        <rfc822;linux-leds@vger.kernel.org>);
        Thu, 29 Dec 2016 16:39:57 -0500
In-Reply-To: <963119a2-efe4-86ef-16a8-85e5f4487b66@gmail.com>
Sender: linux-leds-owner@vger.kernel.org
List-Id: linux-leds@vger.kernel.org
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Joachim Eastwood <manabian@gmail.com>, Riku Voipio <riku.voipio@iki.fi>, Richard Purdie <rpurdie@rpsys.net>, Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, kbuild-all@01.org



On Thu, 29 Dec 2016, Jacek Anaszewski wrote:

> Hi Julia,
>
> This patch doesn't apply to current for-next branch
> of linux-leds.git.

The information about where it comes from is below the ---.  It's
automatically send to me by kbuild, so I don't know anything more than
that.  I recall from the original message that the code was committed
around an hour ago.

julia

> Best regards,
> Jacek Anaszewski
>
> On 12/29/2016 10:10 PM, Julia Lawall wrote:
> > Device node iterators put the previous value of the index variable, so an
> > explicit put causes a double put.
> >
> > Generated by: scripts/coccinelle/iterators/device_node_continue.cocci
> >
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> >
> > I haven't looked at the context in detail, but given the rule, I assume
> > that there is an iterator, such as for_each_child_of_node, and these
> > iterators do a put on each iteration, so none is needed in the loop body.
> >
> > tree:   https://github.com/manabian/linux-lpc lpc18xx_43xx_devel
> > head:   9ee5f58bbb16c08da223c4b4933457e0eb72268d
> > commit: c58957273142be779f62c17fae389ce9c134139f [44/55] leds: pca9532: use
> >
> >  leds-pca9532.c |    3 ---
> >  1 file changed, 3 deletions(-)
> >
> > --- a/drivers/leds/leds-pca9532.c
> > +++ b/drivers/leds/leds-pca9532.c
> > @@ -473,7 +473,6 @@ pca9532_of_populate_pdata(struct device
> >
> >  		res = of_property_read_u32(child, "reg", &reg);
> >  		if ((res != 0) || (reg >= maxleds)) {
> > -			of_node_put(child);
> >  			continue;
> >  		}
> >
> > @@ -484,8 +483,6 @@ pca9532_of_populate_pdata(struct device
> >  		of_property_read_u32(child, "type", &pdata->leds[reg].type);
> >  		of_property_read_string(child, "linux,default-trigger",
> >  					&pdata->leds[reg].default_trigger);
> > -
> > -		of_node_put(child);
> >  	}
> >
> >  	return pdata;
> >
>
>