From: Eric Woudstra <ericwouds@gmail.com>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Christian Marangi <ansuelsmth@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Li Zetao <lizetao1@huawei.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] leds: trigger: netdev: add 2500 link speed mode
Date: Fri, 1 Dec 2023 16:10:53 +0100 [thread overview]
Message-ID: <b0288a8f-d16c-4db6-a4f9-32050531feb0@gmail.com> (raw)
In-Reply-To: <20231201150247.4556-1-ericwouds@gmail.com>
Never mind, thanks, I see just a few days ago this is already send in.
On 12/1/23 16:02, Eric Woudstra wrote:
> This will be useful for PHY leds where the PHY supports 2500Mbps.
>
> Changes to be committed:
> modified: drivers/leds/trigger/ledtrig-netdev.c
> modified: include/linux/leds.h
>
> Signed-off-by: Eric Woudstra <ericwouds@gmail.com>
> ---
> drivers/leds/trigger/ledtrig-netdev.c | 12 +++++++++++-
> include/linux/leds.h | 1 +
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c
> index e358e77e4b38..66dfd327ee5b 100644
> --- a/drivers/leds/trigger/ledtrig-netdev.c
> +++ b/drivers/leds/trigger/ledtrig-netdev.c
> @@ -99,6 +99,10 @@ static void set_baseline_state(struct led_netdev_data *trigger_data)
> trigger_data->link_speed == SPEED_1000)
> blink_on = true;
>
> + if (test_bit(TRIGGER_NETDEV_LINK_2500, &trigger_data->mode) &&
> + trigger_data->link_speed == SPEED_2500)
> + blink_on = true;
> +
> if (test_bit(TRIGGER_NETDEV_HALF_DUPLEX, &trigger_data->mode) &&
> trigger_data->duplex == DUPLEX_HALF)
> blink_on = true;
> @@ -286,6 +290,7 @@ static ssize_t netdev_led_attr_show(struct device *dev, char *buf,
> case TRIGGER_NETDEV_LINK_10:
> case TRIGGER_NETDEV_LINK_100:
> case TRIGGER_NETDEV_LINK_1000:
> + case TRIGGER_NETDEV_LINK_2500:
> case TRIGGER_NETDEV_HALF_DUPLEX:
> case TRIGGER_NETDEV_FULL_DUPLEX:
> case TRIGGER_NETDEV_TX:
> @@ -316,6 +321,7 @@ static ssize_t netdev_led_attr_store(struct device *dev, const char *buf,
> case TRIGGER_NETDEV_LINK_10:
> case TRIGGER_NETDEV_LINK_100:
> case TRIGGER_NETDEV_LINK_1000:
> + case TRIGGER_NETDEV_LINK_2500:
> case TRIGGER_NETDEV_HALF_DUPLEX:
> case TRIGGER_NETDEV_FULL_DUPLEX:
> case TRIGGER_NETDEV_TX:
> @@ -334,7 +340,8 @@ static ssize_t netdev_led_attr_store(struct device *dev, const char *buf,
> if (test_bit(TRIGGER_NETDEV_LINK, &mode) &&
> (test_bit(TRIGGER_NETDEV_LINK_10, &mode) ||
> test_bit(TRIGGER_NETDEV_LINK_100, &mode) ||
> - test_bit(TRIGGER_NETDEV_LINK_1000, &mode)))
> + test_bit(TRIGGER_NETDEV_LINK_1000, &mode) ||
> + test_bit(TRIGGER_NETDEV_LINK_2500, &mode)))
> return -EINVAL;
>
> cancel_delayed_work_sync(&trigger_data->work);
> @@ -364,6 +371,7 @@ DEFINE_NETDEV_TRIGGER(link, TRIGGER_NETDEV_LINK);
> DEFINE_NETDEV_TRIGGER(link_10, TRIGGER_NETDEV_LINK_10);
> DEFINE_NETDEV_TRIGGER(link_100, TRIGGER_NETDEV_LINK_100);
> DEFINE_NETDEV_TRIGGER(link_1000, TRIGGER_NETDEV_LINK_1000);
> +DEFINE_NETDEV_TRIGGER(link_2500, TRIGGER_NETDEV_LINK_2500);
> DEFINE_NETDEV_TRIGGER(half_duplex, TRIGGER_NETDEV_HALF_DUPLEX);
> DEFINE_NETDEV_TRIGGER(full_duplex, TRIGGER_NETDEV_FULL_DUPLEX);
> DEFINE_NETDEV_TRIGGER(tx, TRIGGER_NETDEV_TX);
> @@ -422,6 +430,7 @@ static struct attribute *netdev_trig_attrs[] = {
> &dev_attr_link_10.attr,
> &dev_attr_link_100.attr,
> &dev_attr_link_1000.attr,
> + &dev_attr_link_2500.attr,
> &dev_attr_full_duplex.attr,
> &dev_attr_half_duplex.attr,
> &dev_attr_rx.attr,
> @@ -519,6 +528,7 @@ static void netdev_trig_work(struct work_struct *work)
> test_bit(TRIGGER_NETDEV_LINK_10, &trigger_data->mode) ||
> test_bit(TRIGGER_NETDEV_LINK_100, &trigger_data->mode) ||
> test_bit(TRIGGER_NETDEV_LINK_1000, &trigger_data->mode) ||
> + test_bit(TRIGGER_NETDEV_LINK_2500, &trigger_data->mode) ||
> test_bit(TRIGGER_NETDEV_HALF_DUPLEX, &trigger_data->mode) ||
> test_bit(TRIGGER_NETDEV_FULL_DUPLEX, &trigger_data->mode);
> interval = jiffies_to_msecs(
> diff --git a/include/linux/leds.h b/include/linux/leds.h
> index aa16dc2a8230..c2ae68df50e2 100644
> --- a/include/linux/leds.h
> +++ b/include/linux/leds.h
> @@ -588,6 +588,7 @@ enum led_trigger_netdev_modes {
> TRIGGER_NETDEV_LINK_10,
> TRIGGER_NETDEV_LINK_100,
> TRIGGER_NETDEV_LINK_1000,
> + TRIGGER_NETDEV_LINK_2500,
> TRIGGER_NETDEV_HALF_DUPLEX,
> TRIGGER_NETDEV_FULL_DUPLEX,
> TRIGGER_NETDEV_TX,
prev parent reply other threads:[~2023-12-01 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 15:02 [PATCH RFC] leds: trigger: netdev: add 2500 link speed mode Eric Woudstra
2023-12-01 15:10 ` Eric Woudstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0288a8f-d16c-4db6-a4f9-32050531feb0@gmail.com \
--to=ericwouds@gmail.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).