Linux LED subsystem development
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Florian Eckert <fe@dev.tdt.de>, kernel test robot <lkp@intel.com>
Cc: u.kleine-koenig@pengutronix.de, gregkh@linuxfoundation.org,
	pavel@ucw.cz, lee@kernel.org, oe-kbuild-all@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
	Eckert.Florian@googlemail.com
Subject: Re: [PATCH v5 2/2] trigger: ledtrig-tty: add additional modes
Date: Wed, 22 Feb 2023 08:21:16 +0100	[thread overview]
Message-ID: <b130702a-9886-f18f-c377-489db1cee067@kernel.org> (raw)
In-Reply-To: <4e5aeac3-2a99-8fd5-cf1d-a35870ecd807@kernel.org>

On 22. 02. 23, 8:16, Jiri Slaby wrote:
>>> vim +9 Documentation/ABI/testing/sysfs-class-led-trigger-tty
>>>
>>>    > 9    Date:        January 2023
>>
>> I apologies for the question! But I don't know what the test buildbot 
>> here wants from me.
>> I've looked at the other files and I can't find anything that stands out.
> 
> sphinx is always misleading.
> 
> It's the indentation of all "LED on if ...".

So this should work:

                 Specifies the operating to trigger the LED.
                 The following operating modes are supported:

                 * Tx/Rx: Flash LED on data transmission (default)
                 * CTS:   DCE Ready to accept data from the DTE.
                   LED on if line is high.
                 * DSR:   DCE is ready to receive and send data.
                   LED on if line is high.
                 * CAR:   DCE is receiving a carrier from a remote DTE.
                   LED on if line is high.
                 * RNG:   DCE has detected an incoming ring signal.
                   LED on if line is high.

-- 
js
suse labs


      reply	other threads:[~2023-02-22  7:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21  8:18 [PATCH v5 0/2] leds: ledtrig-tty: add tty_led_mode xtension Florian Eckert
2023-02-21  8:19 ` [PATCH v5 1/2] tty: new helper function tty_get_mget Florian Eckert
2023-02-21  8:19 ` [PATCH v5 2/2] trigger: ledtrig-tty: add additional modes Florian Eckert
2023-02-22  0:02   ` kernel test robot
2023-02-22  6:07     ` Florian Eckert
2023-02-22  7:16       ` Jiri Slaby
2023-02-22  7:21         ` Jiri Slaby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b130702a-9886-f18f-c377-489db1cee067@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=Eckert.Florian@googlemail.com \
    --cc=fe@dev.tdt.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pavel@ucw.cz \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox