From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4E50C4CECF for ; Mon, 23 Sep 2019 15:24:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A7C420820 for ; Mon, 23 Sep 2019 15:24:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="kPFr+FOa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725966AbfIWPYY (ORCPT ); Mon, 23 Sep 2019 11:24:24 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:59626 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbfIWPYY (ORCPT ); Mon, 23 Sep 2019 11:24:24 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x8NFOIvP093861; Mon, 23 Sep 2019 10:24:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1569252258; bh=tLkDVFQOcgXKvvnUWQcn8FwnumQeqXVs0+qEVTBQ6DM=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=kPFr+FOaCTCRJKkfoQBxgbqPe1uBT6Yt/jlsqq/8n4BKEA383j0Dl7VrtWz0eq5b3 QjE0Ot7CjNl+AVunK/MXapVNBqR8Iyb092XC+4OXnqpj/9j6mip6WCr4Y/VRMjYXtQ gMdOam5EIUCaa1CD1/9lyRTgqxVZHSFXIRK6Va/0= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x8NFOIWf043563 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Sep 2019 10:24:18 -0500 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 23 Sep 2019 10:24:17 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 23 Sep 2019 10:24:17 -0500 Received: from [10.250.65.13] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x8NFOH6x070861; Mon, 23 Sep 2019 10:24:17 -0500 Subject: Re: [PATCH v8 7/9] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers To: Jacek Anaszewski , CC: , References: <20190920174139.30079-1-dmurphy@ti.com> <20190920174139.30079-8-dmurphy@ti.com> <73a95bac-7433-5b06-5701-c742307aa004@gmail.com> From: Dan Murphy Message-ID: Date: Mon, 23 Sep 2019 10:28:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <73a95bac-7433-5b06-5701-c742307aa004@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Jacek On 9/21/19 10:13 AM, Jacek Anaszewski wrote: > Dan, > > On 9/20/19 7:41 PM, Dan Murphy wrote: >> Introduce the bindings for the Texas Instruments LP5036, LP5030, LP5024, >> LP5018, LP5012 and LP5009 RGB LED device driver. The LP5036/30/24/18/12/9 >> can control RGB LEDs individually or as part of a control bank group. >> These devices have the ability to adjust the mixing control for the RGB >> LEDs to obtain different colors independent of the overall brightness of >> the LED grouping. >> >> Datasheet: >> http://www.ti.com/lit/ds/symlink/lp5012.pdf >> http://www.ti.com/lit/ds/symlink/lp5024.pdf >> http://www.ti.com/lit/ds/symlink/lp5036.pdf >> >> Signed-off-by: Dan Murphy >> --- >> .../devicetree/bindings/leds/leds-lp50xx.txt | 148 ++++++++++++++++++ >> 1 file changed, 148 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-lp50xx.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.txt b/Documentation/devicetree/bindings/leds/leds-lp50xx.txt >> new file mode 100644 >> index 000000000000..9d05f43042e0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.txt >> @@ -0,0 +1,148 @@ >> +* Texas Instruments - LP5009/12/18/24/30/36 RGB LED driver >> + >> +The LP50XX is multi-channel, I2C RGB LED Drivers that can group RGB LEDs into >> +a LED group or control them individually. >> + >> +The difference in these RGB LED drivers is the number of supported RGB modules. >> + >> +Required parent properties: >> + - compatible: >> + "ti,lp5009" >> + "ti,lp5012" >> + "ti,lp5018" >> + "ti,lp5024" >> + "ti,lp5030" >> + "ti,lp5036" >> + - reg : I2C slave address >> + lp5009/12 - 0x28 >> + lp5018/24 - 0x28 >> + lp5030/36 - 0x30 >> + - #address-cells : 1 >> + - #size-cells : 0 >> + >> +Optional parent properties: >> + - enable-gpios : gpio pin to enable/disable the device. >> + - vled-supply : LED supply >> + >> +Required child properties: >> + - #address-cells : 1 >> + - #size-cells : 0 >> + - reg : This is the LED module number. >> + - color : see Documentation/devicetree/bindings/leds/common.txt >> + - function : see Documentation/devicetree/bindings/leds/common.txt >> + >> +Required child properties only is LED modules will be banked: >> + - ti,led-bank : This property denotes the LED module numbers that will >> + be controlled as a single RGB cluster. Each LED module >> + number will be controlled by a single LED class instance. >> + There can only be one instance of the ti,led-bank >> + property for each device node. >> + >> +Required grandchildren properties: >> + - reg : A single entry denoting the LED module that controls >> + the RGB cluster. >> + - color : see Documentation/devicetree/bindings/leds/leds-multicolor.txt >> + - led-sources : see Documentation/devicetree/bindings/leds/common.txt >> + >> +The LED outputs associated with the LED modules are defined in Table 1 of the >> +corresponding data sheets. > We must enclose this information here. That will make this doc pretty messy especially with the LP5036 entries. I would have to do ascii art to make it understandable and basically there is not a delta in the lesser devices in the outputs I don't see value in reproducing this data sheet contents in the dt-bindings. For example (LP5012) and then for the LP5036 multiply this by 3 Table 1. Bank Number and LED Number Assignment OUT NUMBER BANK NUMBER  RGB LED MODULE NUMBER OUT0                    Bank A OUT1                    Bank B                        LED0 OUT2                    Bank C OUT3                    Bank A OUT4                    Bank B                        LED1 OUT5                    Bank C OUT6                    Bank A OUT7                    Bank B                        LED2 OUT8                    Bank C OUT9 (LP5012 only) Bank A OUT10 (LP5012 only) Bank B                  LED3 OUT11 (LP5012 only) Bank C > >> + >> +LP5009 - 2 Total RGB cluster LED outputs 0-1 This should be 3 total not 2 Dan >> +LP5012 - 4 Total RGB cluster LED outputs 0-3 >> +LP5018 - 6 Total RGB cluster LED outputs 0-5 >> +LP5024 - 8 Total RGB cluster LED outputs 0-7 >> +LP5030 - 10 Total RGB cluster LED outputs 0-9 >> +LP5036 - 12 Total RGB cluster LED outputs 0-11 >> + >> +Optional child properties: >> + - label : see Documentation/devicetree/bindings/leds/common.txt >> + - linux,default-trigger : >> + see Documentation/devicetree/bindings/leds/common.txt >> + >> +Examples: >> +led-controller@29 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + compatible = "ti,lp5024"; >> + reg = <0x29>; >> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; >> + vled-supply = <&vmmcsd_fixed>; >> + >> + multi-led@1 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <1>; >> + color = ; >> + function = LED_FUNCTION_STATUS; >> + >> + led@3 { >> + reg = <3>; >> + color = ; >> + }; >> + >> + led@4 { >> + reg = <4>; >> + color = ; >> + }; >> + >> + led@5 { >> + reg = <5>; >> + color = ; >> + }; >> + }; >> + >> + multi-led@2 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <2>; >> + color = ; >> + function = LED_FUNCTION_STANDBY; >> + ti,led-bank = <2 3 5>; >> + >> + led@6 { >> + reg = <0x6>; >> + color = ; >> + led-sources = <6 9 15>; >> + }; >> + >> + led@7 { >> + reg = <0x7>; >> + color = ; >> + led-sources = <7 10 16>; >> + }; >> + >> + led@8 { >> + reg = <0x8>; >> + color = ; >> + led-sources = <8 11 17>; >> + }; >> + }; >> + >> + multi-led@4 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <4>; >> + color = ; >> + function = LED_FUNCTION_ACTIVITY; >> + >> + led@12 { >> + reg = <12>; >> + color = ; >> + }; >> + >> + led@13 { >> + reg = <13>; >> + color = ; >> + }; >> + >> + led@14 { >> + reg = <14>; >> + color = ; >> + }; >> + }; >> +}; >> + >> +For more product information please see the link below: >> +http://www.ti.com/lit/ds/symlink/lp5012.pdf >> +http://www.ti.com/lit/ds/symlink/lp5024.pdf >> +http://www.ti.com/lit/ds/symlink/lp5036.pdf >>