From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Subject: Re: [PATCH v5 1/6] regulator: lm363x: Make the gpio register enable flexible Date: Wed, 5 Jun 2019 11:32:02 -0500 Message-ID: References: <20190604174345.14841-1-dmurphy@ti.com> <20190604174345.14841-2-dmurphy@ti.com> <20190605100132.GL2456@sirena.org.uk> <7ba7a633-1a39-adcc-e942-12c0eb7c3b16@ti.com> <054c3715-e85f-e052-faf1-057bf3a67d45@ti.com> <20190605163120.GR2456@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190605163120.GR2456@sirena.org.uk> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, lgirdwood@gmail.com, lee.jones@linaro.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-leds@vger.kernel.org Mark On 6/5/19 11:31 AM, Mark Brown wrote: > On Wed, Jun 05, 2019 at 07:47:50AM -0500, Dan Murphy wrote: >> On 6/5/19 7:02 AM, Dan Murphy wrote: >>> I can squash patch 1 into 4. >>> Also not sure what you mean by new validation. >> Disregard I understand.  The patch is missing the validation code. > Ah, some git add issues I guess :) Squashing would help but it's not > essential I think. More like PEBKAC on this one Dan