* [RFC v2 16/39] leds: add HAS_IOPORT dependencies [not found] <20220429135108.2781579-1-schnelle@linux.ibm.com> @ 2022-04-29 13:50 ` Niklas Schnelle 2022-04-29 18:54 ` Pavel Machek 0 siblings, 1 reply; 3+ messages in thread From: Niklas Schnelle @ 2022-04-29 13:50 UTC (permalink / raw) To: Arnd Bergmann Cc: Greg Kroah-Hartman, linux-kernel, linux-arch, linux-pci, Arnd Bergmann, Pavel Machek, open list:LED SUBSYSTEM In a future patch HAS_IOPORT=n will result in inb()/outb() and friends not being declared. We thus need to add HAS_IOPORT as dependency for those drivers using them. Co-developed-by: Arnd Bergmann <arnd@kernel.org> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> --- drivers/leds/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 6090e647daee..d05b7b035b13 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -681,7 +681,7 @@ config LEDS_LM355x config LEDS_OT200 tristate "LED support for the Bachmann OT200" - depends on LEDS_CLASS && HAS_IOMEM && (X86_32 || COMPILE_TEST) + depends on LEDS_CLASS && HAS_IOPORT && (X86_32 || COMPILE_TEST) help This option enables support for the LEDs on the Bachmann OT200. Say Y to enable LEDs on the Bachmann OT200. -- 2.32.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC v2 16/39] leds: add HAS_IOPORT dependencies 2022-04-29 13:50 ` [RFC v2 16/39] leds: add HAS_IOPORT dependencies Niklas Schnelle @ 2022-04-29 18:54 ` Pavel Machek 2022-05-02 8:31 ` Niklas Schnelle 0 siblings, 1 reply; 3+ messages in thread From: Pavel Machek @ 2022-04-29 18:54 UTC (permalink / raw) To: Niklas Schnelle Cc: Arnd Bergmann, Greg Kroah-Hartman, linux-kernel, linux-arch, linux-pci, Arnd Bergmann, open list:LED SUBSYSTEM [-- Attachment #1: Type: text/plain, Size: 531 bytes --] Hi! > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Co-developed-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> I don't see a problem there. Acked-by: Pavel Machek <pavel@ucw.cz> (Its marked RFC so I'm not taking the patch.. right?) Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC v2 16/39] leds: add HAS_IOPORT dependencies 2022-04-29 18:54 ` Pavel Machek @ 2022-05-02 8:31 ` Niklas Schnelle 0 siblings, 0 replies; 3+ messages in thread From: Niklas Schnelle @ 2022-05-02 8:31 UTC (permalink / raw) To: Pavel Machek Cc: Arnd Bergmann, Greg Kroah-Hartman, linux-kernel, linux-arch, linux-pci, Arnd Bergmann, open list:LED SUBSYSTEM On Fri, 2022-04-29 at 20:54 +0200, Pavel Machek wrote: > Hi! > > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > > not being declared. We thus need to add HAS_IOPORT as dependency for > > those drivers using them. > > > > Co-developed-by: Arnd Bergmann <arnd@kernel.org> > > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> > > I don't see a problem there. > > Acked-by: Pavel Machek <pavel@ucw.cz> > > (Its marked RFC so I'm not taking the patch.. right?) > > Best regards, > Pavel Right and thank you. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-02 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220429135108.2781579-1-schnelle@linux.ibm.com>
2022-04-29 13:50 ` [RFC v2 16/39] leds: add HAS_IOPORT dependencies Niklas Schnelle
2022-04-29 18:54 ` Pavel Machek
2022-05-02 8:31 ` Niklas Schnelle
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).