From: Hans de Goede <hdegoede@redhat.com>
To: Henning Schild <henning.schild@siemens.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, Pavel Machek <pavel@ucw.cz>,
Mark Gross <markgross@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Lee Jones <lee@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org
Cc: Sheng-Yuan Huang <syhuang3@nuvoton.com>,
Tasanakorn Phaipool <tasanakorn@gmail.com>,
simon.guinot@sequanux.org
Subject: Re: [PATCH v3 4/4] platform/x86: simatic-ipc: enable watchdog for 227G
Date: Thu, 11 Aug 2022 20:53:13 +0200 [thread overview]
Message-ID: <c6511d80-1b8a-5913-66f3-62ec27f5807c@redhat.com> (raw)
In-Reply-To: <20220811153908.31283-5-henning.schild@siemens.com>
Hi,
On 8/11/22 17:39, Henning Schild wrote:
> Just load the watchdog module, after having identified that machine.
> That watchdog module does not have any autoloading support.
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Patches which are added to review-hans now are intended for
the next rc1. This branch will get rebased to the next rc1 when
it is out and after the rebasing the contents of review-hans
will be pushed to the platform-drivers-x86/for-next branch.
Regards,
Hans
> ---
> drivers/platform/x86/simatic-ipc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/simatic-ipc.c b/drivers/platform/x86/simatic-ipc.c
> index 1825ef21a86d..8dd686d1c9f1 100644
> --- a/drivers/platform/x86/simatic-ipc.c
> +++ b/drivers/platform/x86/simatic-ipc.c
> @@ -96,6 +96,9 @@ static int register_platform_devices(u32 station_id)
> ipc_wdt_platform_device->name);
> }
>
> + if (station_id == SIMATIC_IPC_IPC227G)
> + request_module("w83627hf_wdt");
> +
> if (ledmode == SIMATIC_IPC_DEVICE_NONE &&
> wdtmode == SIMATIC_IPC_DEVICE_NONE) {
> pr_warn("unsupported IPC detected, station id=%08x\n",
next prev parent reply other threads:[~2022-08-11 18:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 15:39 [PATCH v3 0/4] add support for another simatic board Henning Schild
2022-08-11 15:39 ` [PATCH v3 1/4] gpio-f7188x: Add GPIO support for Nuvoton NCT6116 Henning Schild
2022-08-12 8:43 ` simon.guinot
2022-08-12 10:23 ` Henning Schild
2022-08-12 11:22 ` simon.guinot
2022-08-23 9:26 ` Henning Schild
2022-08-22 16:01 ` Henning Schild
[not found] ` <CAHp75VdgKHh+ma34pY=PzS6MB6NWNtzBAADqQmaJgT+couN1Dg@mail.gmail.com>
2022-08-22 13:26 ` Henning Schild
2022-08-22 14:58 ` Henning Schild
2022-08-11 15:39 ` [PATCH v3 2/4] gpio-f7188x: use unique labels for banks/chips Henning Schild
[not found] ` <CAHp75VdWdzsT9wc9BNNKTJ3-eBn3uWdCFXqE2TT+CiJnoTOQYw@mail.gmail.com>
2022-08-22 13:21 ` Henning Schild
2022-08-22 21:36 ` Andy Shevchenko
2022-08-26 8:31 ` Linus Walleij
2022-08-11 15:39 ` [PATCH v3 3/4] leds: simatic-ipc-leds-gpio: add new model 227G Henning Schild
2022-08-11 18:53 ` Hans de Goede
2022-08-11 15:39 ` [PATCH v3 4/4] platform/x86: simatic-ipc: enable watchdog for 227G Henning Schild
2022-08-11 18:53 ` Hans de Goede [this message]
2022-08-11 18:34 ` [PATCH v3 0/4] add support for another simatic board Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6511d80-1b8a-5913-66f3-62ec27f5807c@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=henning.schild@siemens.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=simon.guinot@sequanux.org \
--cc=syhuang3@nuvoton.com \
--cc=tasanakorn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox