From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Subject: Re: [PATCH 2/2] backlight: arcxcnn: add "arctic" vendor prefix Date: Mon, 8 Jul 2019 13:05:00 -0500 Message-ID: References: <1561940895-15837-1-git-send-email-bdodge09@gmail.com> <1561940895-15837-3-git-send-email-bdodge09@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1561940895-15837-3-git-send-email-bdodge09@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Brian Dodge , pavel@ucw.cz Cc: devicetree@vger.kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, jacek.anaszewski@gmail.com, pbacon@psemi.com, lee.jones@linaro.org, linux-leds@vger.kernel.org List-Id: linux-leds@vger.kernel.org QnJpYW4KCk9uIDYvMzAvMTkgNzoyOCBQTSwgQnJpYW4gRG9kZ2Ugd3JvdGU6Cj4gVGhlIG9yaWdp bmFsIHBhdGNoIGFkZGluZyB0aGlzIGRyaXZlciBhbmQgRFQgYmluZGluZ3MgaW1wcm9wZXJseQo+ IHVzZWQgImFyYyIgYXMgdGhlIHZlbmRvci1wcmVmaXguIFRoaXMgYWRkcyAiYXJjdGljIiB3aGlj aCBpcyB0aGUKPiBwcm9wZXIgcHJlZml4IGFuZCByZXRhaW5zICJhcmMiIHRvIGFsbG93IGV4aXN0 aW5nIHVzZXJzIG9mIHRoZQo+ICJhcmMiIHByZWZpeCB0byB1cGRhdGUgdG8gbmV3IGtlcm5lbHMu IFRoZXJlIGlzIGF0IGxlYXN0IG9uZQo+IChTYW1zdW5nIENocm9tZWJvb2sgUGx1cykKPgo+IFNp Z25lZC1vZmYtYnk6IEJyaWFuIERvZGdlIDxiZG9kZ2UwOUBnbWFpbC5jb20+Cj4gQWNrZWQtYnk6 IERhbmllbCBUaG9tcHNvbiA8ZGFuaWVsLnRob21wc29uQGxpbmFyby5vcmc+Cj4gLS0tCj4gICBk cml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9hcmN4Y25uX2JsLmMgfCA0MSArKysrKysrKysrKysrKysr KysrKysrKysrKystLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCsp LCAxMCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdo dC9hcmN4Y25uX2JsLmMgYi9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9hcmN4Y25uX2JsLmMKPiBp bmRleCA3YjFjMGEwLi5hNDE5NTU0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdmlkZW8vYmFja2xp Z2h0L2FyY3hjbm5fYmwuYwo+ICsrKyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2FyY3hjbm5f YmwuYwo+IEBAIC0xLDkgKzEsOSBAQAo+ICAgLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQ TC0yLjAtb25seQo+ICAgLyoKPiAtICogQmFja2xpZ2h0IGRyaXZlciBmb3IgQXJjdGljU2FuZCBB UkNfWF9DXzBOXzBOIERldmljZXMKPiArICogQmFja2xpZ2h0IGRyaXZlciBmb3IgcFNlbWkgKGZv cm1lcmx5IEFyY3RpY1NhbmQpIEFSQ19YX0NfME5fME4gRGV2aWNlcwo+ICAgICoKPiAtICogQ29w eXJpZ2h0IDIwMTYgQXJjdGljU2FuZCwgSW5jLgo+IC0gKiBBdXRob3IgOiBCcmlhbiBEb2RnZSA8 YmRvZGdlQGFyY3RpY3NhbmQuY29tPgoKSSBrbm93IHlvdSBhcmUgdGhlIG9yaWdpbmFsIGF1dGhv ciBmcm9tIEFyY3RpY1NhbmQgYnV0IGRpZCBwU2VtaSAKYWN0dWFsbHkgb3duIHRoZSBjb3B5cmln aHQgaW4gMjAxNj8KCkkgZG9uJ3QgdGhpbmsgdGhpcyBpcyBhIGJpZyBpc3N1ZSBqdXN0IHdvbmRl cmluZyBpZiB3ZSBzaG91bGQgcmV0YWluIHRoZSAKQXJjdGljU2FuZCBjb3B5cmlnaHQgYXMgd2Vs bC4KClByb2JhYmx5IGEgcXVlc3Rpb24gZm9yIHlvdXIgbGVnYWwgZGVwYXJ0bWVudC4KCk90aGVy d2lzZQoKUmV2aWV3ZWQtYnk6IERhbiBNdXJwaHkgPGRtdXJwaHlAdGkuY29tPgoKPiArICogQ29w eXJpZ2h0IDIwMTYtMjAxOSAgcFNlbWksIEluYy4KPiArICogQXV0aG9yIDogQnJpYW4gRG9kZ2Ug PGJkb2RnZUBwc2VtaS5jb20+Cj4gICAgKi8KPiAgIAo+ICAgI2luY2x1ZGUgPGxpbnV4L2JhY2ts aWdodC5oPgo+IEBAIC0xOTEsMjcgKzE5MSw0NiBAQCBzdGF0aWMgdm9pZCBhcmN4Y25uX3BhcnNl X2R0KHN0cnVjdCBhcmN4Y25uICpscCkKPiAgIAlpZiAocmV0ID09IDApCj4gICAJCWxwLT5wZGF0 YS0+aW5pdGlhbF9icmlnaHRuZXNzID0gcHJvZ192YWw7Cj4gICAKPiAtCXJldCA9IG9mX3Byb3Bl cnR5X3JlYWRfdTMyKG5vZGUsICJhcmMsbGVkLWNvbmZpZy0wIiwgJnByb2dfdmFsKTsKPiArCXJl dCA9IG9mX3Byb3BlcnR5X3JlYWRfdTMyKG5vZGUsICJhcmN0aWMsbGVkLWNvbmZpZy0wIiwgJnBy b2dfdmFsKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0ID0gb2ZfcHJvcGVydHlfcmVhZF91MzIobm9k ZSwgImFyYyxsZWQtY29uZmlnLTAiLCAmcHJvZ192YWwpOwo+ICsKPiAgIAlpZiAocmV0ID09IDAp Cj4gICAJCWxwLT5wZGF0YS0+bGVkX2NvbmZpZ18wID0gKHU4KXByb2dfdmFsOwo+ICAgCj4gLQly ZXQgPSBvZl9wcm9wZXJ0eV9yZWFkX3UzMihub2RlLCAiYXJjLGxlZC1jb25maWctMSIsICZwcm9n X3ZhbCk7Cj4gKwlyZXQgPSBvZl9wcm9wZXJ0eV9yZWFkX3UzMihub2RlLCAiYXJjdGljLGxlZC1j b25maWctMSIsICZwcm9nX3ZhbCk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldCA9IG9mX3Byb3BlcnR5 X3JlYWRfdTMyKG5vZGUsICJhcmMsbGVkLWNvbmZpZy0xIiwgJnByb2dfdmFsKTsKPiArCj4gICAJ aWYgKHJldCA9PSAwKQo+ICAgCQlscC0+cGRhdGEtPmxlZF9jb25maWdfMSA9ICh1OClwcm9nX3Zh bDsKPiAgIAo+IC0JcmV0ID0gb2ZfcHJvcGVydHlfcmVhZF91MzIobm9kZSwgImFyYyxkaW0tZnJl cSIsICZwcm9nX3ZhbCk7Cj4gKwlyZXQgPSBvZl9wcm9wZXJ0eV9yZWFkX3UzMihub2RlLCAiYXJj dGljLGRpbS1mcmVxIiwgJnByb2dfdmFsKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0ID0gb2ZfcHJv cGVydHlfcmVhZF91MzIobm9kZSwgImFyYyxkaW0tZnJlcSIsICZwcm9nX3ZhbCk7Cj4gKwo+ICAg CWlmIChyZXQgPT0gMCkKPiAgIAkJbHAtPnBkYXRhLT5kaW1fZnJlcSA9ICh1OClwcm9nX3ZhbDsK PiAgIAo+IC0JcmV0ID0gb2ZfcHJvcGVydHlfcmVhZF91MzIobm9kZSwgImFyYyxjb21wLWNvbmZp ZyIsICZwcm9nX3ZhbCk7Cj4gKwlyZXQgPSBvZl9wcm9wZXJ0eV9yZWFkX3UzMihub2RlLCAiYXJj dGljLGNvbXAtY29uZmlnIiwgJnByb2dfdmFsKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0ID0gb2Zf cHJvcGVydHlfcmVhZF91MzIobm9kZSwgImFyYyxjb21wLWNvbmZpZyIsICZwcm9nX3ZhbCk7Cj4g Kwo+ICAgCWlmIChyZXQgPT0gMCkKPiAgIAkJbHAtPnBkYXRhLT5jb21wX2NvbmZpZyA9ICh1OClw cm9nX3ZhbDsKPiAgIAo+IC0JcmV0ID0gb2ZfcHJvcGVydHlfcmVhZF91MzIobm9kZSwgImFyYyxm aWx0ZXItY29uZmlnIiwgJnByb2dfdmFsKTsKPiArCXJldCA9IG9mX3Byb3BlcnR5X3JlYWRfdTMy KG5vZGUsICJhcmN0aWMsZmlsdGVyLWNvbmZpZyIsICZwcm9nX3ZhbCk7Cj4gKwlpZiAocmV0KQo+ ICsJCXJldCA9IG9mX3Byb3BlcnR5X3JlYWRfdTMyKG5vZGUsCj4gKwkJCQkiYXJjLGZpbHRlci1j b25maWciLCAmcHJvZ192YWwpOwo+ICsKPiAgIAlpZiAocmV0ID09IDApCj4gICAJCWxwLT5wZGF0 YS0+ZmlsdGVyX2NvbmZpZyA9ICh1OClwcm9nX3ZhbDsKPiAgIAo+IC0JcmV0ID0gb2ZfcHJvcGVy dHlfcmVhZF91MzIobm9kZSwgImFyYyx0cmltLWNvbmZpZyIsICZwcm9nX3ZhbCk7Cj4gKwlyZXQg PSBvZl9wcm9wZXJ0eV9yZWFkX3UzMihub2RlLCAiYXJjdGljLHRyaW0tY29uZmlnIiwgJnByb2df dmFsKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0ID0gb2ZfcHJvcGVydHlfcmVhZF91MzIobm9kZSwg ImFyYyx0cmltLWNvbmZpZyIsICZwcm9nX3ZhbCk7Cj4gKwo+ICAgCWlmIChyZXQgPT0gMCkKPiAg IAkJbHAtPnBkYXRhLT50cmltX2NvbmZpZyA9ICh1OClwcm9nX3ZhbDsKPiAgIAo+IEBAIC0zODEs NiArNDAwLDggQEAgc3RhdGljIGludCBhcmN4Y25uX3JlbW92ZShzdHJ1Y3QgaTJjX2NsaWVudCAq Y2wpCj4gICB9Cj4gICAKPiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIGFyY3hj bm5fZHRfaWRzW10gPSB7Cj4gKwl7IC5jb21wYXRpYmxlID0gImFyY3RpYyxhcmMyYzA2MDgiIH0s Cj4gKwkvKiBoZXJlIHRvIHJlbWFpbiBjb21wYXRpYmxlIHdpdGggYW4gb2xkZXIgYmluZGluZywg ZG8gbm90IHVzZSAqLwo+ICAgCXsgLmNvbXBhdGlibGUgPSAiYXJjLGFyYzJjMDYwOCIgfSwKPiAg IAl7IH0KPiAgIH07Cj4gQEAgLTQwNCw1ICs0MjUsNSBAQCBzdGF0aWMgc3RydWN0IGkyY19kcml2 ZXIgYXJjeGNubl9kcml2ZXIgPSB7Cj4gICBtb2R1bGVfaTJjX2RyaXZlcihhcmN4Y25uX2RyaXZl cik7Cj4gICAKPiAgIE1PRFVMRV9MSUNFTlNFKCJHUEwgdjIiKTsKPiAtTU9EVUxFX0FVVEhPUigi QnJpYW4gRG9kZ2UgPGJkb2RnZUBhcmN0aWNzYW5kLmNvbT4iKTsKPiArTU9EVUxFX0FVVEhPUigi QnJpYW4gRG9kZ2UgPGJkb2RnZUBwc2VtaS5jb20+Iik7Cj4gICBNT0RVTEVfREVTQ1JJUFRJT04o IkFSQ1hDTk4gQmFja2xpZ2h0IGRyaXZlciIpOwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BCA9C606C7 for ; Mon, 8 Jul 2019 18:05:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3247B21874 for ; Mon, 8 Jul 2019 18:05:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="dBDfzhoO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730848AbfGHSFu (ORCPT ); Mon, 8 Jul 2019 14:05:50 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:53854 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727413AbfGHSFu (ORCPT ); Mon, 8 Jul 2019 14:05:50 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x68I5gQj024246; Mon, 8 Jul 2019 13:05:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1562609142; bh=wEbRu5aOTp26FP4TWDfUijCXFiai/2iU7BfaaA5fAN4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=dBDfzhoOpie6dafFJ81O8Dg2iNxxIOcT8M/K5LlvPJMLBOGG4vA08UDO1CIgDgO3S 4BH4D0OxKi6M5dklrHO2QzwqTMcMVxagJlCS4xbiUG5T5DPGiS2U4WKrYKVOe0Wn8L xOXpFfJMMqX/BpJue0j+NnQEZQfmMNmaAzJuFFx0= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x68I5ghh040190 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 8 Jul 2019 13:05:42 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 8 Jul 2019 13:05:42 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 8 Jul 2019 13:05:42 -0500 Received: from [10.250.65.13] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x68I5fos046757; Mon, 8 Jul 2019 13:05:41 -0500 Subject: Re: [PATCH 2/2] backlight: arcxcnn: add "arctic" vendor prefix To: Brian Dodge , CC: , , , , , , , , References: <1561940895-15837-1-git-send-email-bdodge09@gmail.com> <1561940895-15837-3-git-send-email-bdodge09@gmail.com> From: Dan Murphy Message-ID: Date: Mon, 8 Jul 2019 13:05:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1561940895-15837-3-git-send-email-bdodge09@gmail.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Message-ID: <20190708180500.907vucnEBt9C5nLAfBHfaVrq841fVxo0n0mxcZyaJSw@z> Brian On 6/30/19 7:28 PM, Brian Dodge wrote: > The original patch adding this driver and DT bindings improperly > used "arc" as the vendor-prefix. This adds "arctic" which is the > proper prefix and retains "arc" to allow existing users of the > "arc" prefix to update to new kernels. There is at least one > (Samsung Chromebook Plus) > > Signed-off-by: Brian Dodge > Acked-by: Daniel Thompson > --- > drivers/video/backlight/arcxcnn_bl.c | 41 +++++++++++++++++++++++++++--------- > 1 file changed, 31 insertions(+), 10 deletions(-) > > diff --git a/drivers/video/backlight/arcxcnn_bl.c b/drivers/video/backlight/arcxcnn_bl.c > index 7b1c0a0..a419554 100644 > --- a/drivers/video/backlight/arcxcnn_bl.c > +++ b/drivers/video/backlight/arcxcnn_bl.c > @@ -1,9 +1,9 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* > - * Backlight driver for ArcticSand ARC_X_C_0N_0N Devices > + * Backlight driver for pSemi (formerly ArcticSand) ARC_X_C_0N_0N Devices > * > - * Copyright 2016 ArcticSand, Inc. > - * Author : Brian Dodge I know you are the original author from ArcticSand but did pSemi actually own the copyright in 2016? I don't think this is a big issue just wondering if we should retain the ArcticSand copyright as well. Probably a question for your legal department. Otherwise Reviewed-by: Dan Murphy > + * Copyright 2016-2019 pSemi, Inc. > + * Author : Brian Dodge > */ > > #include > @@ -191,27 +191,46 @@ static void arcxcnn_parse_dt(struct arcxcnn *lp) > if (ret == 0) > lp->pdata->initial_brightness = prog_val; > > - ret = of_property_read_u32(node, "arc,led-config-0", &prog_val); > + ret = of_property_read_u32(node, "arctic,led-config-0", &prog_val); > + if (ret) > + ret = of_property_read_u32(node, "arc,led-config-0", &prog_val); > + > if (ret == 0) > lp->pdata->led_config_0 = (u8)prog_val; > > - ret = of_property_read_u32(node, "arc,led-config-1", &prog_val); > + ret = of_property_read_u32(node, "arctic,led-config-1", &prog_val); > + if (ret) > + ret = of_property_read_u32(node, "arc,led-config-1", &prog_val); > + > if (ret == 0) > lp->pdata->led_config_1 = (u8)prog_val; > > - ret = of_property_read_u32(node, "arc,dim-freq", &prog_val); > + ret = of_property_read_u32(node, "arctic,dim-freq", &prog_val); > + if (ret) > + ret = of_property_read_u32(node, "arc,dim-freq", &prog_val); > + > if (ret == 0) > lp->pdata->dim_freq = (u8)prog_val; > > - ret = of_property_read_u32(node, "arc,comp-config", &prog_val); > + ret = of_property_read_u32(node, "arctic,comp-config", &prog_val); > + if (ret) > + ret = of_property_read_u32(node, "arc,comp-config", &prog_val); > + > if (ret == 0) > lp->pdata->comp_config = (u8)prog_val; > > - ret = of_property_read_u32(node, "arc,filter-config", &prog_val); > + ret = of_property_read_u32(node, "arctic,filter-config", &prog_val); > + if (ret) > + ret = of_property_read_u32(node, > + "arc,filter-config", &prog_val); > + > if (ret == 0) > lp->pdata->filter_config = (u8)prog_val; > > - ret = of_property_read_u32(node, "arc,trim-config", &prog_val); > + ret = of_property_read_u32(node, "arctic,trim-config", &prog_val); > + if (ret) > + ret = of_property_read_u32(node, "arc,trim-config", &prog_val); > + > if (ret == 0) > lp->pdata->trim_config = (u8)prog_val; > > @@ -381,6 +400,8 @@ static int arcxcnn_remove(struct i2c_client *cl) > } > > static const struct of_device_id arcxcnn_dt_ids[] = { > + { .compatible = "arctic,arc2c0608" }, > + /* here to remain compatible with an older binding, do not use */ > { .compatible = "arc,arc2c0608" }, > { } > }; > @@ -404,5 +425,5 @@ static struct i2c_driver arcxcnn_driver = { > module_i2c_driver(arcxcnn_driver); > > MODULE_LICENSE("GPL v2"); > -MODULE_AUTHOR("Brian Dodge "); > +MODULE_AUTHOR("Brian Dodge "); > MODULE_DESCRIPTION("ARCXCNN Backlight driver");