From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mxout70.expurgate.net (mxout70.expurgate.net [91.198.224.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE9C83874; Wed, 22 Nov 2023 01:50:31 -0800 (PST) Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1r5jsB-00ABvW-6E; Wed, 22 Nov 2023 10:50:19 +0100 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r5jsA-00Ffx0-8r; Wed, 22 Nov 2023 10:50:18 +0100 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id DCBCB240049; Wed, 22 Nov 2023 10:50:17 +0100 (CET) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 390C9240040; Wed, 22 Nov 2023 10:50:17 +0100 (CET) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 9CA4133A3D; Wed, 22 Nov 2023 10:50:16 +0100 (CET) Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Wed, 22 Nov 2023 10:50:16 +0100 From: Florian Eckert To: Lee Jones Cc: m.brock@vanmierlo.com, Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, pavel@ucw.cz, kabel@kernel.org, u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [Patch v8 6/6] leds: ledtrig-tty: add additional line state evaluation In-Reply-To: <20231121152336.GC173820@google.com> References: <20231109085038.371977-1-fe@dev.tdt.de> <20231109085038.371977-7-fe@dev.tdt.de> <39e7c892299c74821b1105a0967063ca@vanmierlo.com> <20231117121253.GB137434@google.com> <20231121152336.GC173820@google.com> Message-ID: X-Sender: fe@dev.tdt.de User-Agent: Roundcube Webmail/1.3.17 Content-Transfer-Encoding: quoted-printable X-purgate-type: clean X-purgate-ID: 151534::1700646619-6487AC7C-A443B82E/0/0 X-purgate: clean On 2023-11-21 16:23, Lee Jones wrote: > On Mon, 20 Nov 2023, Florian Eckert wrote: >=20 >>=20 >>=20 >> On 2023-11-17 13:12, Lee Jones wrote: >> > On Thu, 09 Nov 2023, m.brock@vanmierlo.com wrote: >> > >> > > Florian Eckert schreef op 2023-11-09 09:50: >> > > > The serial tty interface also supports additional input signals,= that >> > > > can also be evaluated within this trigger. This change is adding= the >> > > > following additional input sources, which could be controlled >> > > > via the '/sys/class//' sysfs interface. >> > > > >> > > > Explanation: >> > > > DCE =3D Data Communication Equipment (Modem) >> > > > DTE =3D Data Terminal Equipment (Computer) >> > > > >> > > > - cts: >> > > > DCE is ready to accept data from the DTE (CTS =3D Clear To Sen= d). If >> > > > the line state is detected, the LED is switched on. >> > > > If set to 0 (default), the LED will not evaluate CTS. >> > > > If set to 1, the LED will evaluate CTS. >> > > > >> > > > - dsr: >> > > > DCE is ready to receive and send data (DSR =3D Data Set Ready)= . If the >> > > > line state is detected, the LED is switched on. >> > > > If set to 0 (default), the LED will not evaluate DSR. >> > > > If set to 1, the LED will evaluate DSR. >> > > > >> > > > - dcd: >> > > > DTE is receiving a carrier from the DCE (DCD =3D Data Carrier = Detect). >> > > > If the line state is detected, the LED is switched on. >> > > > If set to 0 (default), the LED will not evaluate DCD. >> > > > If set to 1, the LED will evaluate DCD. >> > > > >> > > > - rng: >> > > > DCE has detected an incoming ring signal on the telephone line >> > > > (RNG =3D Ring Indicator). If the line state is detected, the L= ED is >> > > > switched on. >> > > > If set to 0 (default), the LED will not evaluate RNG. >> > > > If set to 1, the LED will evaluate RNG. >> > > > >> > > > Also add an invert flag on LED blink, so that the LED blinks in = the >> > > > correct order. >> > > > >> > > > * If one off the new enabled input signals are evaluatet as 'ena= bled', >> > > > and data are transmitted, then the LED should first blink 'off= ' and >> > > > then 'on' (invert). >> > > > * If all the new enabled input signals are evaluatet as 'disable= d', >> > > > and data are transmitted, then the LED should first blink 'on'= and >> > > > then 'off'. >> > > > >> > > > Signed-off-by: Florian Eckert >> > > > --- >> > > > .../ABI/testing/sysfs-class-led-trigger-tty | 40 ++++++++++ >> > > > drivers/leds/trigger/ledtrig-tty.c | 77 ++++++++++++= ++++++- >> > > > 2 files changed, 116 insertions(+), 1 deletion(-) >> > >> > [...] >> > >> > > Reviewed-by: Maarten Brock >> > >> > Please snip your replies. >>=20 >> Is there anything I can do? Or do I have to do something? Please give=20 >> me >> more detailed instructions >=20 > That instruction wasn't for you. >=20 > This patch is still on my INCOMING list. >=20 > Do you have Greg's blessing yet? The summary of my v8: The changes for the tty layer on v5 in 'drivers/tty/tty_io.c' got an 'Acked-by: Greg Kroah-Hartman' [1]. I have always added his 'Acked-by' to the following patch series. And I did not made changes to this. So I think I have his blessing for this changes in his maintained tty layer. The Memory leak patch I send during v7 [2] got a comment from Greg, that I have to send this also to=20 'linux-kernel@vger-kernel.org' So this should go into the stable branch [3]. This got an 'Reviewed-by: Uwe Kleine-K=C3=B6nig' [4]. I add this to v8 [5]. So far I don't know if this has already been merged into the master and then backported into the stable branches?. For the changes in the ledtrig-tty driver I am still waiting for an complete 'ACK' or 'NOK' whether I should change something. I have added all of Greg's requested changes in v5 [6]: * split this series * Add the requested change * Switch the driver to use completion for 'sysfs' As I understand it, he handed over the review to the LED subsystem team=20 [7]. I then added a few more changes that came from Maarten in v7 [8]. I got his 'Reviewed-by: Maarten Brock' for v8 on patch 6/6. The patches 4/6 and 5/6 of the v8 still waiting for review? Best regards Florian [1]=20 https://lore.kernel.org/linux-leds/2023102327-rename-kosher-bf03@gregkh/#= t [2]=20 https://lore.kernel.org/linux-leds/2023110629-scenic-rounding-905f@gregkh= / [3]=20 https://lore.kernel.org/linux-leds/20231106141205.3376954-1-fe@dev.tdt.de= / [4]=20 https://lore.kernel.org/linux-leds/20231106144914.bflq2jxejdxs6zjb@pengut= ronix.de/ [5]=20 https://lore.kernel.org/linux-leds/20231109085038.371977-1-fe@dev.tdt.de/= T/#m1f0c4680749812f1a933667128f73995efe66bca [6]=20 https://lore.kernel.org/linux-leds/2023102341-jogger-matching-dded@gregkh= / [7]=20 https://lore.kernel.org/linux-leds/2023102333-skewer-reclining-8d04@gregk= h/ [8]=20 https://lore.kernel.org/linux-leds/bc94f31e965be6f640c286f8c8a2cf38@vanmi= erlo.com/ [9]=20 https://lore.kernel.org/linux-leds/39e7c892299c74821b1105a0967063ca@vanmi= erlo.com/