From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Brophy <Professor_jonny@hotmail.com>,
"Rob Herring (Arm)" <robh@kernel.org>,
Jonathan Brophy <professorjonny98@gmail.com>
Cc: Andriy Shevencho <andriy.shevchenko@linux.intel.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
lee Jones <lee@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Pavel Machek <pavel@kernel.org>,
Radoslav Tsvetkov <rtsvetkov@gradotech.eu>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 3/7] dt-bindings: leds: Add virtual LED group controller bindings
Date: Wed, 31 Dec 2025 09:03:21 +0100 [thread overview]
Message-ID: <cfe39a0e-e475-4d0d-bad6-461b25f430ef@kernel.org> (raw)
In-Reply-To: <DS0PR84MB3746BAB4FEB95BA7AB47BECB9FBCA@DS0PR84MB3746.NAMPRD84.PROD.OUTLOOK.COM>
On 30/12/2025 09:32, Jonathan Brophy wrote:
>> My bot found errors running 'make dt_binding_check' on your patch:
>
>> yamllint warnings/errors:
>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.example.dtb: pwm-led-controller (pwm->leds): 'led-pwm-blue', 'led-pwm-green', 'led-pwm-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', '^pinctrl-[0-9]+$'
>
>
> Thanks I have fixed this and re submitted a v5 patch series.
>
> I have been testing on OpenWrt where the yaml and dts files are not validated and this slipped in.
>
You must base and test on mainline, not OpenWRT. I understand above that
v5 wasn't tested either, so I won't be reviewing it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-31 8:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 0:32 [PATCH v4 0/7] leds: Add virtual LED group driver with priority arbitration Jonathan Brophy
2025-12-30 0:32 ` [PATCH 1/7] dt-bindings: leds: add function virtual_status to led common properties Jonathan Brophy
2025-12-30 0:32 ` [PATCH v4 2/7] dt-bindings: leds: Add virtual LED class bindings Jonathan Brophy
2025-12-30 0:32 ` [PATCH v4 3/7] dt-bindings: leds: Add virtual LED group controller bindings Jonathan Brophy
2025-12-30 1:26 ` Rob Herring (Arm)
2025-12-30 8:32 ` Jonathan Brophy
2025-12-31 8:03 ` Krzysztof Kozlowski [this message]
2025-12-30 0:32 ` [PATCH v4 4/7] ABI: Add sysfs documentation for leds-group-virtualcolor Jonathan Brophy
2025-12-30 0:32 ` [PATCH v4 5/7] leds: Add driver " Jonathan Brophy
2025-12-30 15:24 ` kernel test robot
2025-12-30 0:32 ` [PATCH v4 6/7] leds: Add fwnode_led_get() for firmware-agnostic LED resolution Jonathan Brophy
2025-12-30 16:07 ` kernel test robot
2025-12-30 0:32 ` [PATCH 7/7] leds: Add virtual LED group driver with priority arbitration Jonathan Brophy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfe39a0e-e475-4d0d-bad6-461b25f430ef@kernel.org \
--to=krzk@kernel.org \
--cc=Professor_jonny@hotmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=professorjonny98@gmail.com \
--cc=robh@kernel.org \
--cc=rtsvetkov@gradotech.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox