From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A2F8C3DA7A for ; Wed, 21 Dec 2022 08:14:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234495AbiLUIOA (ORCPT ); Wed, 21 Dec 2022 03:14:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234486AbiLUIN5 (ORCPT ); Wed, 21 Dec 2022 03:13:57 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D54AC21279 for ; Wed, 21 Dec 2022 00:13:54 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id m29so22123210lfo.11 for ; Wed, 21 Dec 2022 00:13:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pkbnwNlIzbD+fefyBrKzBY3j56R66zu85H+p/b4oFEA=; b=UYdFilbWV7A+MZV/xySGbrRhz0Lb+GMht44Sq5YuuyEiDxacld1b9d/v4rYJugfOC4 Md5gkhjhx5Hfw22SfE/EnHFav2afuKzeY94VJ5FReAHyqsHynikwpY237myDLKq0yjJH xj2VXCkrzY5gxnsa3NZbomL9VHFnWRh6wxFHrFasg6EtIkw0W78m/sHHaJP8G59RNsXP dH2jQU9T8Lc+2GWcYDmentJpjGpV6tgrkrr2ToLF1In4KjfdA8l6kTpJtAobq72W7EXR ub36dXcQSwd3OagUOC99tWjbNhTc9meepMaizVwpfn5Cz/PC5bO3g2/3L5aE8rV54TKF aBjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pkbnwNlIzbD+fefyBrKzBY3j56R66zu85H+p/b4oFEA=; b=lg0Y1tp491bt+yFrL/c90r4rRtgad8dn8OKit6yB/hcJmf1Rcl8aPgF21AXqb19oJ3 Ak0iw2NHjgrQtaDD+Zg2mRASqFc7nTeVrGwNr7CSvHkPCM3gmWgdKxU0/TXRxpSZGmaa ogxBo+AMELBb8DG2xE8lDLXUPADGz3u/IpMpxKy31iu37Prx9Hm6ADSzLBhG/BaAWwvx A9LAx/oSB9qJs7BhRHkebgW/geKpSqc+ApNsRhjJW5XCgyoZ0m8TZUxJtYwhJ+MwR6OC qM2zfzzcfuRSY7lsWltXGoouoi01ULRnpgY1z2iLX33ZI07d2Iro5aowV3wt1tCX+VgD 2qlA== X-Gm-Message-State: AFqh2kpM4LVT4Rb5ANoJLvVBSW9FcwjZ5uQCq4kN8l02godo2lq/U1XE 2VWJ6L6BWL7wAiUDzPxPJNAFYNr/YeXthHf1 X-Google-Smtp-Source: AMrXdXt1jk8G9ZKPcFxKLxyW5hblcLez4+qRH9QHQR4npD+m5WNzpAqhc0NnY5gNKmhQO+Hv4OoEbQ== X-Received: by 2002:a05:6512:6d6:b0:4a4:68b9:609b with SMTP id u22-20020a05651206d600b004a468b9609bmr366616lff.38.1671610433245; Wed, 21 Dec 2022 00:13:53 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id o18-20020a05651238b200b004ac6a444b26sm1769606lft.141.2022.12.21.00.13.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 00:13:52 -0800 (PST) Message-ID: Date: Wed, 21 Dec 2022 09:13:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight Content-Language: en-US To: Jianhua Lu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org References: <20221221070216.17850-1-lujianhua000@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20221221070216.17850-1-lujianhua000@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 21/12/2022 08:02, Jianhua Lu wrote: > Add device tree bindings for the Kinetic KTZ8866 backlight driver. 1. Your patches are not properly threaded which makes it difficult to review and handle them. Resend with proper threads. 2. Subject: drop second, redundant "binding for". > > Signed-off-by: Jianhua Lu > --- > .../leds/backlight/kinetic,ktz8866.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > > diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > new file mode 100644 > index 000000000000..7286c3fc7f5d > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Kinetic Technologies KTZ8866 backlight > + > +maintainers: > + - Jianhua Lu > + > +description: | > + The Kinetic Technologies KTZ8866 is a high efficiency 6-sinks led backlight > + with dual lcd bias power. > + https://www.kinet-ic.com/ktz8866/ > + > +allOf: > + - $ref: common.yaml# > + > +properties: > + compatible: > + items: > + const: kinetic,ktz8866 Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > + > +required: > + - compatible > + > +additionalProperties: false This should be rather unevaluatedProperties: false, otherwise you do not allow any other properties, except compatible. Was this the intention? Best regards, Krzysztof