From: Heiner Kallweit <hkallweit1@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH] leds: Don't emit brightness set error message if LED supports hw triggers only
Date: Mon, 1 Nov 2021 13:47:26 +0100 [thread overview]
Message-ID: <d98dd377-4a1c-8c57-e3e3-11c78475d1a8@gmail.com> (raw)
In-Reply-To: <20211101115910.GA2571@duo.ucw.cz>
On 01.11.2021 12:59, Pavel Machek wrote:
> Hi!
>
>
>> Working on a driver for specific network LEDs that support HW triggers
>> only I got error "Setting an LED's brightness failed" when switching
>> to a different trigger. This is caused by call
>> led_set_brightness(led_cdev, LED_OFF) in led_trigger_set() because
>> both brigthness_set callbacks are not implemented. Let's suppress
>> the error message in that case.
>
> Hmm... do we have such LEDs in tree? LED supporting only hardware
> triggers is kind of unusual/interesting/and I'm not really sure if we
> should have them in LED subsystem.
>
This was when working on network LED support for r8169 where you can
select between a number of HW triggers only. IIRC the discussion how
to support such network LEDs didn't really come to a conclusion yet.
Having said that at least my work hasn't been upstreamed yet.
> Best regards,
> Pavel
>
Heiner
next prev parent reply other threads:[~2021-11-01 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 20:25 [PATCH] leds: Don't emit brightness set error message if LED supports hw triggers only Heiner Kallweit
2021-11-01 11:59 ` Pavel Machek
2021-11-01 12:47 ` Heiner Kallweit [this message]
2021-11-01 12:48 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d98dd377-4a1c-8c57-e3e3-11c78475d1a8@gmail.com \
--to=hkallweit1@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).