From: Florian Fainelli <f.fainelli@gmail.com>
To: Christian Marangi <ansuelsmth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Jonathan Corbet <corbet@lwn.net>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
John Crispin <john@phrozen.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [net-next PATCH v7 02/16] net: dsa: qca8k: add LEDs basic support
Date: Mon, 17 Apr 2023 11:28:55 -0700 [thread overview]
Message-ID: <daf43ba4-22e1-7e07-57b8-ac4a3f82adc4@gmail.com> (raw)
In-Reply-To: <20230417151738.19426-3-ansuelsmth@gmail.com>
On 4/17/23 08:17, Christian Marangi wrote:
> Add LEDs basic support for qca8k Switch Family by adding basic
> brightness_set() support.
>
> Since these LEDs refelect port status, the default label is set to
> ":port". DT binding should describe the color and function of the
> LEDs using standard LEDs api.
> Each LED always have the device name as prefix. The device name is
> composed from the mii bus id and the PHY addr resulting in example
> names like:
> - qca8k-0.0:00:amber:lan
> - qca8k-0.0:00:white:lan
> - qca8k-0.0:01:amber:lan
> - qca8k-0.0:01:white:lan
>
> These LEDs supports only blocking variant of the brightness_set()
> function since they can sleep during access of the switch leds to set
> the brightness.
>
> While at it add to the qca8k header file each mode defined by the Switch
> Documentation for future use.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2023-04-17 18:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 15:17 [net-next PATCH v7 00/16] net: Add basic LED support for switch/phy Christian Marangi
2023-04-17 15:17 ` [net-next PATCH v7 01/16] net: dsa: qca8k: move qca8k_port_to_phy() to header Christian Marangi
2023-04-17 15:17 ` [net-next PATCH v7 02/16] net: dsa: qca8k: add LEDs basic support Christian Marangi
2023-04-17 18:28 ` Florian Fainelli [this message]
2023-04-17 15:17 ` [net-next PATCH v7 03/16] net: dsa: qca8k: add LEDs blink_set() support Christian Marangi
2023-04-17 15:17 ` [net-next PATCH v7 04/16] leds: Provide stubs for when CLASS_LED & NEW_LEDS are disabled Christian Marangi
2023-04-17 15:17 ` [net-next PATCH v7 05/16] net: phy: Add a binding for PHY LEDs Christian Marangi
2023-04-17 18:26 ` Florian Fainelli
2023-04-17 15:17 ` [net-next PATCH v7 06/16] net: phy: phy_device: Call into the PHY driver to set LED brightness Christian Marangi
2023-04-17 15:17 ` [net-next PATCH v7 07/16] net: phy: marvell: Add software control of the LEDs Christian Marangi
2023-04-17 15:17 ` [net-next PATCH v7 08/16] net: phy: phy_device: Call into the PHY driver to set LED blinking Christian Marangi
2023-04-17 15:17 ` [net-next PATCH v7 09/16] net: phy: marvell: Implement led_blink_set() Christian Marangi
2023-04-17 15:17 ` [net-next PATCH v7 10/16] dt-bindings: net: ethernet-controller: Document support for LEDs node Christian Marangi
2023-04-17 15:17 ` [net-next PATCH v7 11/16] dt-bindings: net: dsa: qca8k: add LEDs definition example Christian Marangi
2023-04-17 15:17 ` [net-next PATCH v7 12/16] ARM: dts: qcom: ipq8064-rb3011: Drop unevaluated properties in switch nodes Christian Marangi
2023-04-17 15:17 ` [net-next PATCH v7 13/16] ARM: dts: qcom: ipq8064-rb3011: Add Switch LED for each port Christian Marangi
2023-04-19 12:53 ` Krzysztof Kozlowski
2023-04-19 14:38 ` Christian Marangi
2023-04-19 18:15 ` Krzysztof Kozlowski
2023-04-17 15:17 ` [net-next PATCH v7 14/16] dt-bindings: net: phy: Document support for LEDs node Christian Marangi
2023-04-17 15:17 ` [net-next PATCH v7 15/16] arm: mvebu: dt: Add PHY LED support for 370-rd WAN port Christian Marangi
2023-04-17 15:17 ` [net-next PATCH v7 16/16] Documentation: LEDs: Describe good names for network LEDs Christian Marangi
2023-04-19 4:27 ` [net-next PATCH v7 00/16] net: Add basic LED support for switch/phy Jakub Kicinski
2023-04-19 12:20 ` Andrew Lunn
2023-04-19 12:21 ` Andrew Lunn
2023-04-19 12:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daf43ba4-22e1-7e07-57b8-ac4a3f82adc4@gmail.com \
--to=f.fainelli@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregory.clement@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).