From: Randy Dunlap <rdunlap@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Milo Kim <milo.kim@ti.com>,
Mathias Nyman <mathias.nyman@nokia.com>
Subject: [PATCH -next] leds: fix LEDS_LP55XX_COMMON dependency and build errors
Date: Mon, 27 Jul 2020 16:57:11 -0700 [thread overview]
Message-ID: <dba79c02-b7f1-dd75-b364-93d90538cc5e@infradead.org> (raw)
From: Randy Dunlap <rdunlap@infradead.org>
Make LEDS_LP55XX_COMMON depend on I2C to fix build errors:
leds-lp55xx-common.c:(.text+0x9d): undefined reference to `i2c_smbus_read_byte_data'
leds-lp55xx-common.c:(.text+0x8fc): undefined reference to `i2c_smbus_write_byte_data'
These errors happened when I2C=m and LEDS_LP55XX_COMMON=y, so
prevent that from being possible.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: linux-leds@vger.kernel.org
Cc: Milo Kim <milo.kim@ti.com>
Cc: Mathias Nyman <mathias.nyman@nokia.com>
---
drivers/leds/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20200727.orig/drivers/leds/Kconfig
+++ linux-next-20200727/drivers/leds/Kconfig
@@ -399,6 +399,7 @@ config LEDS_LP55XX_COMMON
tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501"
depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR
depends on OF
+ depends on I2C
select FW_LOADER
select FW_LOADER_USER_HELPER
help
next reply other threads:[~2020-07-27 23:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 23:57 Randy Dunlap [this message]
2020-07-28 10:26 ` [PATCH -next] leds: fix LEDS_LP55XX_COMMON dependency and build errors Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dba79c02-b7f1-dd75-b364-93d90538cc5e@infradead.org \
--to=rdunlap@infradead.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mathias.nyman@nokia.com \
--cc=milo.kim@ti.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).