linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vincent Knecht <vincent.knecht@mailoo.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Pavel Machek <pavel@ucw.cz>,
	linux-leds@vger.kernel.org, hns@goldelico.com
Subject: Re: [PATCH v1 RESEND 1/7] dt-bindings: leds: Convert is31fl319x to dtschema
Date: Thu, 30 Jun 2022 23:43:26 +0200	[thread overview]
Message-ID: <dcd817c8a3852f3e6bad0c221a284fb3e69e1ca9.camel@mailoo.org> (raw)
In-Reply-To: <20220630152806.GA2732671-robh@kernel.org>

Le jeudi 30 juin 2022 à 09:28 -0600, Rob Herring a écrit :
> On Tue, Jun 28, 2022 at 08:09:39PM -0600, Rob Herring wrote:
> > On Tue, 28 Jun 2022 20:21:39 +0200, Vincent Knecht wrote:
> > > Convert leds-is31fl319x.txt to dtschema.
> > > Set license to the one recommended by DT project.
> 
> Do you have permission to do so? The original .txt file is default GPL2 
> and owned by H. Nikolaus Schaller. 

No, sorry for the mistake.
Adding to cc, which I forgot to do in the first place...
For reference: https://lore.kernel.org/linux-leds/20220628182147.2837180-1-vincent.knecht@mailoo.org/T/

> > > 
> > > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> > > ---
> > >  .../bindings/leds/issi,is31fl319x.yaml        | 113 ++++++++++++++++++
> > >  .../bindings/leds/leds-is31fl319x.txt         |  61 ----------
> > >  2 files changed, 113 insertions(+), 61 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/leds/issi,is31fl319x.yaml
> > >  delete mode 100644 Documentation/devicetree/bindings/leds/leds-is31fl319x.txt
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml:
> > patternProperties:^thermistor@:properties:adi,excitation-current-nanoamp: '$ref' should not be valid under {'const':
> > '$ref'}
> >         hint: Standard unit suffix properties don't need a type $ref
> >         from schema $id: http://devicetree.org/meta-schemas/core.yaml#
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring,
> > error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp
> > Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.example.dtb:0:0: /example-0/spi/ltc2983@0: failed to
> > match any schema with compatible: ['adi,ltc2983']
> 
> You can ignore this. The bot went amuck.
> 

Ack... at least it respected the 3 Laws :-)




  reply	other threads:[~2022-06-30 21:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-28 18:21 [PATCH v1 RESEND 0/7] Fix/Add is31fl319{0,1,3} support Vincent Knecht
2022-06-28 18:21 ` [PATCH v1 RESEND 1/7] dt-bindings: leds: Convert is31fl319x to dtschema Vincent Knecht
2022-06-29  2:09   ` Rob Herring
2022-06-30 15:28     ` Rob Herring
2022-06-30 21:43       ` Vincent Knecht [this message]
2022-07-01 16:34         ` H. Nikolaus Schaller
2022-06-28 18:21 ` [PATCH v1 RESEND 2/7] dt-bindings: leds: is31fl319x: Add missing si-en compatibles Vincent Knecht
2022-06-28 18:21 ` [PATCH v1 RESEND 3/7] " Vincent Knecht
2022-06-28 18:21 ` [PATCH v1 RESEND 4/7] dt-bindings: leds: is31fl319x: Document variants specificities Vincent Knecht
2022-06-29  8:29   ` Krzysztof Kozlowski
2022-06-28 18:21 ` [PATCH v1 RESEND 5/7] leds: is31fl319x: Use non-wildcard names for vars, structs and defines Vincent Knecht
2022-06-28 18:21 ` [PATCH v1 RESEND 6/7] leds: is31fl319x: Move chipset-specific values in chipdef struct Vincent Knecht
2022-06-28 18:21 ` [PATCH v1 RESEND 7/7] leds: is31fl319x: Add support for is31fl319{0,1,3} chips Vincent Knecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcd817c8a3852f3e6bad0c221a284fb3e69e1ca9.camel@mailoo.org \
    --to=vincent.knecht@mailoo.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hns@goldelico.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).