From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>,
robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net,
pavel@ucw.cz, sakari.ailus@iki.fi,
laurent.pinchart@ideasonboard.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 1/2] leds: as3645a: Fix quoted string split warning
Date: Thu, 14 Dec 2017 22:11:03 +0100 [thread overview]
Message-ID: <df3a8f78-fec9-d75e-cc13-b1ed30009d0e@gmail.com> (raw)
In-Reply-To: <20171214173727.10070-1-dmurphy@ti.com>
Hi Dan,
Thanks for the patch set.
Bot patches applied to the for-next branch.
--
Best regards,
Jacek Anaszewski
On 12/14/2017 06:37 PM, Dan Murphy wrote:
> Fix a warning for a split quoted string across
> lines.
>
> WARNING: quoted string split across lines
> 459: FILE: drivers/leds/leds-as3645a.c:459:
> dev_err(dev, "AS3645A not detected "
> "(model %d rfu %d)\n", model, rfu);
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v2 - Split the warning fixes into 2 patches and fixed commit message -
> https://patchwork.kernel.org/patch/10108325/
>
> drivers/leds/leds-as3645a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
> index 9a257f969300..49fdd7c0a6f6 100644
> --- a/drivers/leds/leds-as3645a.c
> +++ b/drivers/leds/leds-as3645a.c
> @@ -455,8 +455,8 @@ static int as3645a_detect(struct as3645a *flash)
>
> /* Verify the chip model and version. */
> if (model != 0x01 || rfu != 0x00) {
> - dev_err(dev, "AS3645A not detected "
> - "(model %d rfu %d)\n", model, rfu);
> + dev_err(dev, "AS3645A not detected (model %d rfu %d)\n",
> + model, rfu);
> return -ENODEV;
> }
>
>
prev parent reply other threads:[~2017-12-14 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 17:37 [PATCH v2 1/2] leds: as3645a: Fix quoted string split warning Dan Murphy
[not found] ` <20171214173727.10070-1-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-14 17:37 ` [PATCH v2 2/2] leds: as3645a: Fix line over 80 characters Dan Murphy
2017-12-14 18:04 ` [PATCH v2 1/2] leds: as3645a: Fix quoted string split warning Sakari Ailus
2017-12-14 21:11 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df3a8f78-fec9-d75e-cc13-b1ed30009d0e@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).