From: Dan Scally <dan.scally@ideasonboard.com>
To: Kate Hsuan <hpa@redhat.com>, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee@kernel.org>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Daniel Scally <djrscally@gmail.com>,
Mark Gross <markgross@kernel.org>
Subject: Re: [RESEND PATCH 2/3] include: mfd: tps68470: Add masks for LEDA and LEDB
Date: Fri, 24 Feb 2023 14:29:47 +0000 [thread overview]
Message-ID: <e094f558-166b-c936-0621-f50af47dab71@ideasonboard.com> (raw)
In-Reply-To: <20230213124520.1635257-3-hpa@redhat.com>
Hi Kate - thanks for the set
On 13/02/2023 12:45, Kate Hsuan wrote:
> Add flags for both LEDA(TPS68470_ILEDCTL_ENA), LEDB
> (TPS68470_ILEDCTL_ENB), and current control mask for LEDB
> (TPS68470_ILEDCTL_CTRLB)
>
> Signed-off-by: Kate Hsuan <hpa@redhat.com>
> ---
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> include/linux/mfd/tps68470.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/mfd/tps68470.h b/include/linux/mfd/tps68470.h
> index 7807fa329db0..2d2abb25b944 100644
> --- a/include/linux/mfd/tps68470.h
> +++ b/include/linux/mfd/tps68470.h
> @@ -34,6 +34,7 @@
> #define TPS68470_REG_SGPO 0x22
> #define TPS68470_REG_GPDI 0x26
> #define TPS68470_REG_GPDO 0x27
> +#define TPS68470_REG_ILEDCTL 0x28
> #define TPS68470_REG_VCMVAL 0x3C
> #define TPS68470_REG_VAUX1VAL 0x3D
> #define TPS68470_REG_VAUX2VAL 0x3E
> @@ -94,4 +95,8 @@
> #define TPS68470_GPIO_MODE_OUT_CMOS 2
> #define TPS68470_GPIO_MODE_OUT_ODRAIN 3
>
> +#define TPS68470_ILEDCTL_ENA BIT(2)
> +#define TPS68470_ILEDCTL_ENB BIT(6)
> +#define TPS68470_ILEDCTL_CTRLB GENMASK(5, 4)
> +
> #endif /* __LINUX_MFD_TPS68470_H */
next prev parent reply other threads:[~2023-02-24 14:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 12:45 [RESEND PATCH 0/3] leds: tps68470: LED driver for TPS68470 Kate Hsuan
2023-02-13 12:45 ` [RESEND PATCH 1/3] platform: x86: int3472: Add MFD cell for tps68470 LED Kate Hsuan
2023-02-22 16:33 ` Hans de Goede
2023-02-13 12:45 ` [RESEND PATCH 2/3] include: mfd: tps68470: Add masks for LEDA and LEDB Kate Hsuan
2023-02-22 16:34 ` Hans de Goede
2023-02-24 14:29 ` Dan Scally [this message]
2023-02-13 12:45 ` [RESEND PATCH 3/3] leds: tps68470: Add LED control for tps68470 Kate Hsuan
2023-02-22 16:53 ` Hans de Goede
2023-02-24 15:14 ` Dan Scally
2023-03-01 12:37 ` Hans de Goede
2023-03-02 8:36 ` Kate Hsuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e094f558-166b-c936-0621-f50af47dab71@ideasonboard.com \
--to=dan.scally@ideasonboard.com \
--cc=djrscally@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox