From: Vincent Knecht <vincent.knecht@mailoo.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH v3 0/6] leds: Fix/Add is31fl319{0,1,3} support
Date: Sat, 09 Jul 2022 11:51:43 +0200 [thread overview]
Message-ID: <e17913649e255d91bc357d3ab3e70957d05493e6.camel@mailoo.org> (raw)
In-Reply-To: <CAHp75VfwoSqLZVbsN3DduP=SEKvr=tSfmxF1MTnYma0zh-JsXQ@mail.gmail.com>
Le mardi 05 juillet 2022 à 20:57 +0200, Andy Shevchenko a écrit :
> On Tue, Jul 5, 2022 at 6:32 PM Vincent Knecht <vincent.knecht@mailoo.org> wrote:
> >
> > v3:
> > - pick up Rob's R-b for patches 1 and 2
> > - reinstate bindings docs license and maintainer
> > changes with Nikolaus agreement
> > - took Andy's comments on patch 4 into account
>
> Thanks for the update. Nothing serious, but a few comments.
>
> Also a question here. Do you have plans to convert it to use device properties?
Hi Andy, and thank you for the reviews.
Just sent a v4:
https://lore.kernel.org/linux-leds/20220709094642.4078222-1-vincent.knecht@mailoo.org/
As for converting to device properties, it will take me some more time
since I'm not too familiar with the concepts and how to do it exactly.
Got some hints from git history, will look into that.
Also I'd like to add blink support...
next prev parent reply other threads:[~2022-07-09 9:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 16:31 [PATCH v3 0/6] leds: Fix/Add is31fl319{0,1,3} support Vincent Knecht
2022-07-05 16:31 ` [PATCH v3 1/6] dt-bindings: leds: Convert is31fl319x to dtschema Vincent Knecht
2022-07-05 16:31 ` [PATCH v3 2/6] dt-bindings: leds: is31fl319x: Document variants specificities Vincent Knecht
2022-07-05 16:31 ` [PATCH v3 3/6] leds: is31fl319x: Add missing si-en compatibles Vincent Knecht
2022-07-05 16:31 ` [PATCH v3 4/6] leds: is31fl319x: Use non-wildcard names for vars, structs and defines Vincent Knecht
2022-07-05 18:47 ` Andy Shevchenko
2022-07-05 16:31 ` [PATCH v3 5/6] leds: is31fl319x: Move chipset-specific values in chipdef struct Vincent Knecht
2022-07-05 18:51 ` Andy Shevchenko
2022-07-05 16:31 ` [PATCH v3 6/6] leds: is31fl319x: Add support for is31fl319{0,1,3} chips Vincent Knecht
2022-07-05 18:56 ` Andy Shevchenko
2022-07-05 18:57 ` [PATCH v3 0/6] leds: Fix/Add is31fl319{0,1,3} support Andy Shevchenko
2022-07-09 9:51 ` Vincent Knecht [this message]
2022-07-11 21:39 ` Andy Shevchenko
2022-07-11 21:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e17913649e255d91bc357d3ab3e70957d05493e6.camel@mailoo.org \
--to=vincent.knecht@mailoo.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).