Re: [PATCH v6 6/8] pinctrl: Add RTL8231 pin control and GPIO support

[Sander Vanheule <sander@svanheule.net>]

Hi Linus,

On Wed, 2025-10-22 at 09:42 +0200, Linus Walleij wrote:
> Hi Sander,
> 
> thanks for your patch!
> 
> Overall this driver looks very good and well designed, using the
> right abstractions and everything.

Thanks!

> The build bots are complaining but I think you will have fixed that
> in no time.

Indeed, I reproduced it on a UM build and resolved it by changing the underlying type for
enum rtl8231_pin_function to uintptr_t.

Additionally, this showed that I was missing CONFIG_GPIOLIB, so PINCTRL_RTL8231 now
selects that as well.

> 
> Just one minor comment:
> 
> On Tue, Oct 21, 2025 at 4:24 PM Sander Vanheule <sander@svanheule.net> wrote:
> 
> > This driver implements the GPIO and pin muxing features provided by the
> > RTL8231. The device should be instantiated as an MFD child, where the
> > parent device has already configured the regmap used for register
> > access.
> 
> This is Realtek, right?
> 
> >  drivers/pinctrl/pinctrl-rtl8231.c | 538 ++++++++++++++++++++++++++++++
> 
> Should we put the driver in
> drivers/pinctrl/realtek/*?

Like you noticed, this is for an external chip, so I also decided to not move it to that
directory.

Best,
Sander