From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85110C433FE for ; Mon, 23 May 2022 13:07:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235977AbiEWNHV (ORCPT ); Mon, 23 May 2022 09:07:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235874AbiEWNHT (ORCPT ); Mon, 23 May 2022 09:07:19 -0400 Received: from smtpout1.mo528.mail-out.ovh.net (smtpout1.mo528.mail-out.ovh.net [46.105.34.251]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3F2C49935; Mon, 23 May 2022 06:07:15 -0700 (PDT) Received: from pro2.mail.ovh.net (unknown [10.109.138.188]) by mo528.mail-out.ovh.net (Postfix) with ESMTPS id D667410363FD1; Mon, 23 May 2022 15:07:13 +0200 (CEST) Received: from [192.168.1.42] (88.161.25.233) by DAG1EX2.emp2.local (172.16.2.2) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Mon, 23 May 2022 15:07:13 +0200 Message-ID: Date: Mon, 23 May 2022 15:07:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/3] dt-bindings: leds: Add bindings for the TLC5925 controller Content-Language: en-US To: Krzysztof Kozlowski , Pavel Machek , Rob Herring , Krzysztof Kozlowski CC: , , References: <20220523084958.2723943-1-jjhiblot@traphandler.com> <20220523084958.2723943-2-jjhiblot@traphandler.com> From: Jean-Jacques Hiblot In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [88.161.25.233] X-ClientProxiedBy: CAS4.emp2.local (172.16.1.4) To DAG1EX2.emp2.local (172.16.2.2) X-Ovh-Tracer-Id: 9728056670395120091 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrjedugdeftdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfhisehtjeertddtfeejnecuhfhrohhmpeflvggrnhdqlfgrtghquhgvshcujfhisghlohhtuceojhhjhhhisghlohhtsehtrhgrphhhrghnughlvghrrdgtohhmqeenucggtffrrghtthgvrhhnpeeugfevvdeludefkeejleetvdejueduvddtteejfeejvdevheekueefiefhlefgkeenucffohhmrghinhepuggvvhhitggvthhrvggvrdhorhhgnecukfhppedtrddtrddtrddtpdekkedrudeiuddrvdehrddvfeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehprhhovddrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehjjhhhihgslhhothesthhrrghphhgrnhgulhgvrhdrtghomhdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 23/05/2022 12:14, Krzysztof Kozlowski wrote: > On 23/05/2022 10:49, Jean-Jacques Hiblot wrote: >> Add bindings documentation for the TLC5925 LED controller. >> >> Signed-off-by: Jean-Jacques Hiblot > Thank you for your patch. There is something to discuss/improve. Thanks for the review. I didn't know about dt_binding_check. I'll make sure it passes next time. JJ >> --- >> devicetree@vger.kernel.org >> .../bindings/leds/leds-tlc5925.yaml | 100 ++++++++++++++++++ >> 1 file changed, 100 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-tlc5925.yaml >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-tlc5925.yaml b/Documentation/devicetree/bindings/leds/leds-tlc5925.yaml >> new file mode 100644 >> index 000000000000..156db599d5a1 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-tlc5925.yaml > Filename: vendor,device > so "ti,tlc5925-leds.yaml" for example. > > > >> @@ -0,0 +1,100 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/leds/leds-tlc5925.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: LEDs connected to TI TLC5925 controller >> + >> +maintainers: >> + - Jean-Jacques Hiblot >> + >> +description: | >> + The TLC5925 is a low-power 16-channel constant-current LED sink driver. >> + It is controlled through a SPI interface. >> + It is built around a shift register and latches which convert serial >> + input data into a parallel output. Several TLC5925 can be chained to >> + control more than 16 LEDs with a single chip-select. >> + The brightness level cannot be controlled, each LED is either on or off. >> + >> + Each LED is represented as a sub-node of the ti,tlc5925 device. >> + >> +properties: >> + compatible: >> + const: ti,tlc5925 >> + >> + shift_register_length: >> + maxItems: 1 > No... > 1. Did you test your bindings with dt_binding_check? This fails > obviously... please, do not send untested bindings. > > 2. vendor prefix, no underscores, proper type, maxItems look wrong here > >> + description: | >> + The length of the shift register. If several TLC5925 are chained, >> + shift_register_length should be set to 16 times the number of TLC5925. >> + The value must be a multiple of 8. >> + >> + "#address-cells": >> + const: 1 >> + >> + "#size-cells": >> + const: 0 >> + >> + output-enable-b-gpios: >> + description: | >> + GPIO pins to enable/disable the parallel output. They describe the GPIOs >> + connected to the OE/ pin of the TLC5925s. > maxItems > > >> + >> +patternProperties: >> + "@[a-f0-9]+$": > How many LEDs you can have here? Usually it is limited, so the pattern > should be narrowed. > >> + type: object >> + >> + $ref: common.yaml# >> + >> + properties: >> + reg: >> + items: > Not correct syntax... I will stop reviewing. There is no point to use > reviewers time to do the job of a tool. > > >> +examples: >> + - | >> + &spi0 { >> + leds@2 { >> + compatible = "ti,tlc5925"; > Messed up indentation. 4 spaces for DTS example. > >> + reg = <0x02>; >> + spi-max-frequency = <30000000>; >> + shift_register_length = <32>; >> + output-enable-b-gpios = <&gpio0b 9 GPIO_ACTIVE_HIGH>, <&gpio0b 7 GPIO_ACTIVE_HIGH>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + led-satus@0 { >> + reg = <0>; >> + function = LED_FUNCTION_STATUS; >> + color = ; >> + }; >> + >> + led-satus@4 { >> + reg = <4>; >> + function = LED_FUNCTION_STATUS; >> + color = ; >> + }; >> + >> + led-alive@24 { >> + reg = <24>; >> + label = "green:alive" >> + }; >> + >> + led-panic@31 { >> + reg = <31>; >> + label = "red:panic" >> + }; >> + }; >> + }; > > Best regards, > Krzysztof