Re: [PATCH] leds: bcm6328: fix signal source assignment for leds 4 to 7

[Jacek Anaszewski <jacek.anaszewski@gmail.com>]

Hi Jonas,

On 06/02/2017 02:17 PM, Jonas Gorski wrote:
> Each nibble represents 4 LEDs, and in case of the higher register, bit 0
> represents LED 4, so we need to use modulus for the LED number as well.
> 
> Fixes: fd7b025a238d0a5440bfa26c585eb78097bf48dc ("leds: add BCM6328 LED driver")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> ---
>  drivers/leds/leds-bcm6328.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/leds-bcm6328.c b/drivers/leds/leds-bcm6328.c
> index 1548259297c1..2cfd9389ee96 100644
> --- a/drivers/leds/leds-bcm6328.c
> +++ b/drivers/leds/leds-bcm6328.c
> @@ -242,7 +242,7 @@ static int bcm6328_hwled(struct device *dev, struct device_node *nc, u32 reg,
>  
>  		spin_lock_irqsave(lock, flags);
>  		val = bcm6328_led_read(addr);
> -		val |= (BIT(reg) << (((sel % 4) * 4) + 16));
> +		val |= (BIT(reg % 4) << (((sel % 4) * 4) + 16));
>  		bcm6328_led_write(addr, val);
>  		spin_unlock_irqrestore(lock, flags);
>  	}
> @@ -269,7 +269,7 @@ static int bcm6328_hwled(struct device *dev, struct device_node *nc, u32 reg,
>  
>  		spin_lock_irqsave(lock, flags);
>  		val = bcm6328_led_read(addr);
> -		val |= (BIT(reg) << ((sel % 4) * 4));
> +		val |= (BIT(reg % 4) << ((sel % 4) * 4));
>  		bcm6328_led_write(addr, val);
>  		spin_unlock_irqrestore(lock, flags);
>  	}
> 

Thanks for the patch. Applied.

-- 
Best regards,
Jacek Anaszewski