From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v4 1/3] leds: Introduce userspace leds driver Date: Tue, 8 Nov 2016 21:29:27 +0100 Message-ID: References: <1474053410-24387-1-git-send-email-david@lechnology.com> <1474053410-24387-2-git-send-email-david@lechnology.com> <0bfdfd46-35e5-321c-5759-0cc96be862fd@samsung.com> <0970c634-61ac-8ad7-088a-e47419c23455@lechnology.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <0970c634-61ac-8ad7-088a-e47419c23455@lechnology.com> Sender: linux-kernel-owner@vger.kernel.org To: David Lechner , Jacek Anaszewski , Richard Purdie Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Marcel Holtmann , Pavel Machek List-Id: linux-leds@vger.kernel.org On 11/08/2016 08:08 PM, David Lechner wrote: > > > On 11/8/16 5:26 AM, Jacek Anaszewski wrote: >> Hi David, >> > >>> +struct uleds_device { >>> + struct uleds_user_dev user_dev; >>> + struct led_classdev led_cdev; >>> + struct mutex mutex; >>> + enum uleds_state state; >>> + wait_queue_head_t waitq; >>> + unsigned char brightness; >> >> I've just noticed that this is wrong, since LED subsystem >> brightness type is enum led_brightness, i.e. int. >> LED_FULL (255) value is a legacy enum value that can be overridden >> by max_brightness property. >> >> Please submit a fix so that I could merge it with the original >> patch before sending it upstream. >> >> Thanks, >> Jacek Anaszewski >> > > The brightness should be a 32-bit integer then? Exactly. -- Best regards, Jacek Anaszewski