From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
linux-leds@vger.kernel.org, Florian Eckert <fe@dev.tdt.de>
Subject: Re: [PATCH] leds: trigger/tty: Use led_set_brightness_nosleep() to set brightness
Date: Tue, 18 Apr 2023 20:04:50 +0200 [thread overview]
Message-ID: <f1bc92a9-4ffa-dd9f-494a-033db0bd2a32@gmail.com> (raw)
In-Reply-To: <3589aa0c-bea7-f637-8bb9-f597da217401@gmail.com>
On 4/18/23 20:02, Jacek Anaszewski wrote:
> Hi Uwe,
>
> On 4/18/23 00:27, Uwe Kleine-König wrote:
>> hello Jacek,
>>
>> On Mon, Apr 17, 2023 at 09:51:06PM +0200, Jacek Anaszewski wrote:
[...]
>>> int led_set_brightness_nopm_cansleep()
>>> ret =__led_set_brightness();
>>> if (ret == -ENOTSUPP)
>>> ret = __led_set_brightness_blocking();
>>>
>>> return ret;
>>
>> Did you just reinvent led_set_brightness_sync() and the only thing we
>> need is:
>
> Actually you're right, but led_set_brightness_sync() needs to be
> supplemented with the call to __led_set_brightness_blocking().
I meant __led_set_brightness() of course.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2023-04-18 18:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 16:48 [PATCH] leds: trigger/tty: Use led_set_brightness_nosleep() to set brightness Uwe Kleine-König
2023-04-16 15:13 ` Jacek Anaszewski
2023-04-17 7:18 ` Florian Eckert
2023-04-17 12:28 ` Pavel Machek
2023-04-17 12:44 ` Uwe Kleine-König
2023-04-17 18:33 ` Jacek Anaszewski
2023-04-17 19:17 ` Uwe Kleine-König
2023-04-17 19:51 ` Jacek Anaszewski
2023-04-17 22:27 ` Uwe Kleine-König
2023-04-18 18:02 ` Jacek Anaszewski
2023-04-18 18:04 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1bc92a9-4ffa-dd9f-494a-033db0bd2a32@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=fe@dev.tdt.de \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).