From: Andrew Lunn <andrew@lunn.ch>
To: Marek Vasut <marex@denx.de>
Cc: linux-leds@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: phy: Handle both led@0 and led subnode name for single-LED PHYs
Date: Mon, 20 Jan 2025 17:35:22 +0100 [thread overview]
Message-ID: <f2a4d89c-d633-4b18-bc0e-2994a0f76b9e@lunn.ch> (raw)
In-Reply-To: <20250120090256.54382-1-marex@denx.de>
On Mon, Jan 20, 2025 at 10:02:46AM +0100, Marek Vasut wrote:
> In case a PHY supports only one LED in total, like ADIN1300, and this LED
> is described in DT, it is currently necessary to include unit address in
> the LED node name and the address-cells have to be set to 1:
>
> leds {
> #address-cells = <1>;
> ...
> led@0 {
> reg = <0>;
> ...
> };
> };
>
> For a single LED PHY, this should not be necessary and plain 'led' node
> without unit should be acceptable as well:
>
> leds {
> ...
> led {
> ...
> };
> };
So how do other subsystems handle this? SPI with only a single chip
select line? Standalone LED controllers with a single LED? A PWM with
a single output?
> drivers/net/phy/phy_device.c | 15 +++++++++++++--
What about the device tree binding? Does it already have the reg
property as optional?
Andrew
next prev parent reply other threads:[~2025-01-20 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 9:02 [PATCH v2] net: phy: Handle both led@0 and led subnode name for single-LED PHYs Marek Vasut
2025-01-20 16:35 ` Andrew Lunn [this message]
2025-01-21 11:53 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2a4d89c-d633-4b18-bc0e-2994a0f76b9e@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox