From: Krzysztof Kozlowski <krzk@kernel.org>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v7 2/4] dt-bindings: leds: nxp,pca963x: add multicolor LED support
Date: Mon, 27 Jul 2026 10:36:31 +0200 [thread overview]
Message-ID: <f529d0b2-075a-4bf7-a2f5-01bbe1d5418a@kernel.org> (raw)
In-Reply-To: <CAFEp6-1Rciv1qqsYeHLnxKPKXos+hP3FUkgRjXzrTzHDA5cMDg@mail.gmail.com>
On 27/07/2026 10:24, Loic Poulain wrote:
>>> compatible:
>>> @@ -96,10 +136,16 @@ allOf:
>>> - nxp,pca9634
>>> then:
>>> patternProperties:
>>> - "^led@[0-9a-f]+$":
>>> + "^.*led@[0-9a-f]$":
>>
>> Why changing this? multi-led is below, so maybe you wanted to combine
>> both?
>
> Yes, I wanted to combine them so that both multi-led@ and led@ nodes
> have their reg property checked by this filter, while the multi-led@
> filter below only checks the reg property of its led@ subnodes, though
> it may not very clear and also too permissive?
Ah, I see now, damn YAML indentation. Code is not that readable, but
looks fine.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-27 8:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 7:48 [PATCH v7 0/4] leds: pca963x: Add multicolor support and enable Monza RGB LEDs Loic Poulain
2026-07-24 7:48 ` [PATCH v7 1/4] dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635 Loic Poulain
2026-07-24 7:54 ` sashiko-bot
2026-07-24 7:48 ` [PATCH v7 2/4] dt-bindings: leds: nxp,pca963x: add multicolor LED support Loic Poulain
2026-07-24 7:56 ` sashiko-bot
2026-07-27 6:22 ` Krzysztof Kozlowski
2026-07-27 8:24 ` Loic Poulain
2026-07-27 8:36 ` Krzysztof Kozlowski [this message]
2026-07-24 7:48 ` [PATCH v7 3/4] leds: pca963x: add multicolor LED class support Loic Poulain
2026-07-24 8:02 ` sashiko-bot
2026-07-24 7:48 ` [PATCH v7 4/4] arm64: dts: monaco-arduino-monza: microcontroller LEDs Loic Poulain
2026-07-24 7:55 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f529d0b2-075a-4bf7-a2f5-01bbe1d5418a@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox