From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34818282F18 for ; Thu, 15 Oct 2026 01:38:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028314; cv=none; b=fCaXYfunExLGqqg97lW8QP99J2EMW8GgGTNbk9L6/0koa7da+fsowZwZ/aB3dWf5Fk5TnAZ5pEyYNDLiscsuUjwpFMcZSwIEX8sNnFsT4j9uHZhTJBir+FSi4NEQ2GavO/WKCxLDb/YRPCNOwMWOWCmYH30XRXTXR9v6cGaZ3Ug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028314; c=relaxed/simple; bh=/Qgnut9+G6PGmnCXCHz/0qRV+Pfvr0slJqmidKSXVH8=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type:Content-Disposition; b=mU9Mt+reYtukpICISmT8xYsRrN1+VrtYurIrz7QkM3RmKUXa6DRhVMYOTZ1VptNMEiFVzxFPF2a5IgR63HMFO5PQRexzRHZqhxf5hy+zGSDzicRhc6P/MJrIPwg8RfjWvnVKy823uiGn6y7HNuSQSS1TJwaBnrMUG8a8fUsxk/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jLDcTvu4; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jLDcTvu4" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-3535bf8b3e0so2472740eec.0 for ; Wed, 14 Oct 2026 18:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028312; x=1792633112; darn=vger.kernel.org; h=content-disposition:content-transfer-encoding:content-type :mime-version:references:in-reply-to:subject:cc:to:from:message-id :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=biVi8aFmQp7Egr8jmIyP2HiGBUC9LJELcNuVslQ0QHw=; b=jLDcTvu4GlLenPqKYM2b3LOjBa3mCCcitaRC1KHpgVHRFLgY6U+lh5GqxdOjOAeSMZ mmm41fqaAIfJxrjRFW/JlXMNgKq3KutcSbK5/nv1OEROewywV7pnmRaLZsLDZwexRde0 uzga7h3vawE9WH52/R1PBJVFcBuNr1fdCF1GH/rgeF/tR/+PqIR8+ce8UABklOTweAWK 8uyqt2he+4hjxvKgxHChhfHKfYyp5xxpfSNv1QVN+YbOxNhIrDJFafutV+TSg9kKyJoK 3RSvi61YLvC82yrIdoxgJzKX23kBwIasSbgnqQHp/7Kt6DvBcPdegmDYUJlNKHph/aNN jpnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028312; x=1792633112; h=content-disposition:content-transfer-encoding:content-type :mime-version:references:in-reply-to:subject:cc:to:from:message-id :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=biVi8aFmQp7Egr8jmIyP2HiGBUC9LJELcNuVslQ0QHw=; b=cXjWsdSVNITah3lT7LRBXQky7ghgcnPY3MkuoqEWmxVc/NQb+4YpXID+fiP9Ewnz6w uemrY8bB/PZIEZgieZ+o7MPLNqL3YgaVY1t7wEkiOkKddoMYs9mNdOGUY+JasGwNUQCt gzpekDsbV3BCAtVIiICpfzdy+PtoMPe/zR4BrjHDIVuU2bSf5or6DhF7R2RrhHKdocua 1cKki92bfpP8tFqYu042f2yW0PPGTggRUSYmsNVQz5nBUnwyV48nA33o9e4J4XDcid+E OLWM2zn4qE0AoOEKe254M96x4rfYwDoYU5EzVbMbUGpTsaaGuh70IDS5zzp1FwkGT75X nUUg== X-Forwarded-Encrypted: i=1; AKwUvBzBAl0vqffMPgxrDfCzucch7BxOk54wJypb6iB5VdU9n1Mh5ND/qRxDcX8pVZI/WbeH5/yqtcm0AP3g@vger.kernel.org X-Gm-Message-State: AFq9FYKo+N2Nlo+0kN3Ci1cQ+Q1F0Sqq1GlPcMJiMLVzXF8jDCsawUGF 4mogroCP3DM9idv8rN8ynMZ1WBUs1a3U3NIxgHbxo1Ttr1sELu2uYcPI X-Gm-Gg: AYBFou3YBK8aGKjKYtomDCmDMGyFHW4AKplUZZvaJmQG9niIM9kcZN4Mk9elelQcEOC rOGkqDVQCP0L4Ks8XCB4SaDZKzGroRKAdZP0KDTYzsiKnqOZI4fPsb3Cyg83TVSUxsDPyvZVsCe qqFZgu57GXNBatkdjBlk4Nvuv9BZlDJURo2rCNzU88hbjGEePe6JXcpB+67GfleBf5a51wj3jTP q0D48EzpveBNyJlA80fdLb6czGxI6xEDWITseaTfgOMzrfSxytz6vI3dfDxDkOUY+JVBWIISzD9 U6xtVolFMQHsz0HM6xLwKKfqrV7xsQjcvoAMX1H3o+aRUDKGbIlXlJVTpACT5j+pl7sfxRsl8bz m8VIw5GUZuerpfa9BrqSVH3ixLOAwOD+8OsVmVGHlkG/lEl1zoyx3uL/Qfa9Z+ZX1GjgIQkWLAr x37WFMJP9j3A1eoNhXC3y5uLt9lXsIL8YsYDMAtrDoy36Cn3ICEOYzUrCT5e8UUrNnVOKEzo2VQ dTkoApByaZathBraHSu1fttrvI0td2k+sG9U9eHWD+q4M9N X-Received: by 2002:a05:7300:d209:b0:35a:47ed:c39a with SMTP id 5a478bee46e88-35a47edc590mr14634414eec.37.1792028312150; Wed, 14 Oct 2026 18:38:32 -0700 (PDT) Received: from localhost ([2a00:79e0:2ebe:8:821:261c:74c2:4177]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3537ca79536sm56907491eec.16.2026.10.14.18.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:38:31 -0700 (PDT) Date: Wed, 14 Oct 2026 18:38:30 -0700 Message-ID: From: Dmitry Torokhov To: Svyatoslav Ryhel Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Pavel Machek , Sebastian Reichel , Ion Agorria , =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= , Florian Krischer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, mfd@lists.linux.dev, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v11 6/7] power: supply: Add driver for ASUS Transformer battery In-Reply-To: <20261013173504.451391-7-clamor95@gmail.com> References: <20261013173504.451391-1-clamor95@gmail.com> <20261013173504.451391-7-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Svyatoslav, On Tue, Oct 13, 2026 at 08:35:02PM +0300, Svyatoslav Ryhel wrote: > +static int asus_ec_battery_get_property(struct power_supply *psy, > + enum power_supply_property psp, > + union power_supply_propval *val) > +{ > + struct asus_ec_battery_data *priv = power_supply_get_drvdata(psy); > + int ret; > + > + switch (psp) { > + case POWER_SUPPLY_PROP_PRESENT: > + val->intval = 1; > + break; > + > + default: > + ret = asus_ec_battery_get_value(priv, psp); > + if (ret < 0) > + return ret; > + > + val->intval = (s16)ret; > + > + switch (psp) { ... > + case POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW: > + case POWER_SUPPLY_PROP_TIME_TO_FULL_NOW: > + val->intval *= 60; > + break; asus_ec_battery_get_value() returns a u16 (via get_unaligned_le16()), and unconditionally casting it with (s16)ret sign-extends unsigned 16-bit properties >= 0x8000 into negative values. In particular, when the battery is not discharging or not charging, TIME_TO_EMPTY_NOW / TIME_TO_FULL_NOW report 0xffff, which (s16)ret turns into -1 and then -60 seconds instead of an unsigned value (or -ENODATA). Should only signed properties (like POWER_SUPPLY_PROP_CURRENT_NOW) be cast to s16? Thanks. -- Dmitry