From: Oleh Kravchenko <oleg@kaa.org.ua>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
devicetree@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 2/2] leds: add LED driver for EL15203000 board
Date: Wed, 14 Aug 2019 23:58:31 +0300 [thread overview]
Message-ID: <f61e7a4e-89dc-26f1-b4fb-aa83ec7f24dc@kaa.org.ua> (raw)
In-Reply-To: <4af185e2-95cf-4e21-f3f0-b35bd39441e3@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2422 bytes --]
By the way,
14.08.19 23:53, Jacek Anaszewski пише:
> On 8/14/19 10:16 PM, Oleh Kravchenko wrote:
>> Hello Jacek,
>>
>> 14.08.19 22:57, Jacek Anaszewski пише:
>>>>>>
>>>>>> All pattern is predefined, you can't change them at all.
>>>>>> I just tried to describe real things what happened in LED board.
>>>>>> It's ticks every 800 milliseconds for Pipe LEDs.
>>>>>
>>>>> It makes me wonder how you figured out the values? If you have
>>>>> a documentation for this controller, could you share how the pattern
>>>>> settings are documented?
>>>>
>>>> I saw the code of firmware.
>>>> Not sure if I can find any documentation for it right now.
>>>
>>> Have you tried to alter the values? Or check what happens when
>>> the duplication is removed?
>>
>> What do you mean alter? It doesn't make any sense.
>> Board is accepts only brightness level from '0' to '5'.
>> I'm really confused :-)
>
> OK, I didn't analyze the driver thoroughly enough.
> Now everything is clear to me. Patterns are triggered just
> by writing two-byte command.
>
>>>>>
>>>>> For the first two we could do without sequence duplication.
>>>>
>>>> Ok, I will reduce it.
>>>
>>> Please hold on for a while. I will have some more remarks to the driver,
>>> just collecting missing info for now to gain more complete view on this
>>> device.
>>
>> Here is the full story:
>>
>> EL15203000 LEDs board (aka RED LEDs board, because it has only RED LEDs).
>> It's provide access to 3 LEDs:
>>
>> - First LED (Screen) is a light tube around big 21" screen
>> It's have 3 brightness levels:
>> * OFF
>> * ON
>> * Breathing mode (8 seconds full cycle)
>
> OK, so this is LED string. We would need to bend rules to make it
> appearing as a single LED class device, but allowing non-synchronous
> blinking of LEDs in the string.
>
>> - Second LED (Vending area) is highlight coffee cap
>> * OFF
>> * ON
>> - Third LED (Pipe) is actually virtual, because consists from 5 LEDs
>> * OFF for all 5 LEDs
>> * ON for all 5 LEDs
>> * Cascade
>> * Inverses cascade
>> * Bounce
>> * Inverses bounce
Full cycle takes 8 seconds too.
So actually it's splitted into 10 stages, each takes 800ms.
> Similarly in case of this one. I will give you a feedback on how
> to define the patterns within few days.
>
Take you time.
--
Best regards,
Oleh Kravchenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-14 20:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 20:32 [PATCH v4 1/2] dt-bindings: Add docs for EL15203000 Oleh Kravchenko
2019-08-08 20:32 ` [PATCH v4 2/2] leds: add LED driver for EL15203000 board Oleh Kravchenko
2019-08-13 20:28 ` Jacek Anaszewski
2019-08-13 20:37 ` Oleh Kravchenko
2019-08-14 18:18 ` Jacek Anaszewski
2019-08-14 19:46 ` Oleh Kravchenko
2019-08-14 19:57 ` Jacek Anaszewski
2019-08-14 20:16 ` Oleh Kravchenko
2019-08-14 20:53 ` Jacek Anaszewski
2019-08-14 20:58 ` Oleh Kravchenko [this message]
2019-08-17 15:02 ` Pavel Machek
2019-08-20 7:46 ` Oleh Kravchenko
2019-08-18 13:47 ` Jacek Anaszewski
2019-08-27 20:43 ` Oleh Kravchenko
2019-08-27 20:56 ` Jacek Anaszewski
2019-08-27 21:11 ` Oleh Kravchenko
2019-08-27 21:18 ` Jacek Anaszewski
2019-08-27 21:26 ` Oleh Kravchenko
2019-08-13 20:31 ` [PATCH v4 1/2] dt-bindings: Add docs for EL15203000 Dan Murphy
2019-08-14 19:54 ` Jacek Anaszewski
2019-08-18 13:41 ` Jacek Anaszewski
2019-08-20 7:50 ` Oleh Kravchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f61e7a4e-89dc-26f1-b4fb-aa83ec7f24dc@kaa.org.ua \
--to=oleg@kaa.org.ua \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox