Re: [PATCH v3 2/4] dt-bindings: leds: Add virtualcolor group dt bindings documentation.

jonathan brophy
2025-10-20T18:00:53Z

On Sun, 21 October 2025 12:35 AM, JRob Herring (Arm) wrote:
>
>
>On Sun, 19 Oct 2025 22:23:25 +1300, Jonathan Brophy wrote:>
>
> From: Jonathan Brophy <professor_jonny@hotmail.com>
>
>
>
>> Add device tree binding documentation for the virtual LED group driver
>>
>> that implements virtual LED groups by aggregating multiple monochromatic
>>
>> LEDs
>>
>>
>
>> Bindings for the virtual driver are not describing hardware LEDs they
>
>> describe virtual devices made from groups of hardware LEDs created from an array
>
>> of LED phandles.
>
>
>
>> Normally the device tree is used to describe hardware not virtual hardware
>
>> but it is particularly useful in situations where you require an LED to be a
>
>> specific color by mixing primary colors, such as multi element multi color LEDs
>
>> to be operated from a device tree binding.
>
>
>> It also becomes useful with multiple LEDs operating the same indicator such as
>
>> ring of light indicators where the LEDs are driven From different GPIO outputs
>
>> unifying the control that can give basic indication during system startup,
>
>> shutdown upgrade etc...
>
>>
>
>> co-developed-by: Radoslav Tsvetkov <rtsvetkov@gradotech.eu>
>
>> Signed-off-by: Radoslav Tsvetkov <rtsvetkov@gradotech.eu>
>
>> Signed-off-by: Jonathan Brophy <professor_jonny@hotmail.com>
>
>> ---
>
>>  .../leds/leds-group-virtualcolor.yaml         | 110 ++++++++++++++++++
>
>>  1 file changed, 110 insertions(+)
>
>>  create mode 100644 Documentation/devicetree/bindings/leds/leds-group-virtualcolor.yaml
>
>
>My bot found errors running 'make dt_binding_check' on your patch:
>
>
>
>yamllint warnings/errors:
>
>
>
>dtschema/dtc warnings/errors:
>
>/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.example.dtb: pwm-led->controller (pwm-leds): led-1: 'max-brightness' is a required property
>
>       from schema $id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
>
>/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.example.dtb: pwm-led->controller (pwm-leds): led-2: 'max-brightness' is a required property
>
>       from schema $id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
>
>/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.example.dtb: pwm-led->controller (pwm-leds): led-3: 'max-brightness' is a required property
>
>       from schema $id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
>
>/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.example.dtb: pwm-led->controller (pwm-leds): led-4: 'max-brightness' is a required property
>
>      from schema $id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
>

sorry this was me checking my yaml's without validating the whole structure as those are covered by their own Yaml's
In futurre I will validate the whole structure.