Re: [PATCH v3 1/4] dt: bindings: Add virtualcolor class dt bindings documentation.

Krzysztof Kozlowski
2025-10-19T10:39:23Z

On 19/10/2025 11:23, Jonathan Brophy wrote:
> From: Jonathan Brophy <professor_jonny@hotmail.com>
>
> Add DT bindings for the LEDs virtualcolor class framework. Add

Why? What part of hardware or real system use case is being solved here?

> LED-FUNCTION-VIRTUAL-STATUS ID to the FUNCTION ID list for device tree
> bindings.
>
> co-developed-by: Radoslav Tsvetkov <rtsvetkov@gradotech.eu>

That's not a proper tag. See submitting patches.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

I don't understand what is happening with your patchset. It is being
changed in unexpected way, like something previously correct - like
subject - now is changed for some unexplained reason.

> Signed-off-by: Radoslav Tsvetkov <rtsvetkov@gradotech.eu>
> Signed-off-by: Jonathan Brophy <professor_jonny@hotmail.com>
> ---
> .../leds/leds-class-virtualcolor.yaml | 90 +++++++++++++++++++
> include/dt-bindings/leds/common.h | 4 +
> 2 files changed, 94 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-class-virtualcolor.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-class-virtualcolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-virtualcolor.yaml
> new file mode 100644
> index 000000000000..8cbbbf0d746c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-class-virtualcolor.yaml
> @@ -0,0 +1,90 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-class-virtualcolor.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: virtualcolor LED class

I don't understand what is "virtualcolor"

> +
> +maintainers:
> + - Radoslav Tsvetkov <rtsvetkov@gradotech.eu>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> + Validates individual virtual LED nodes that aggregate multiple monochromatic

This sentence makes no sense. You describe here hardware in full
sentence. How hardware can "validates"?

Best regards,
Krzysztof