Re: [PATCH v5] leds: max597x: Add support for max597x

[Naresh Solanki <naresh.solanki@9elements.com>]

Hi Lee,

On 24-04-2023 03:10 pm, Naresh Solanki wrote:
> Hi,
> 
> On 21-04-2023 12:49 pm, Lee Jones wrote:
>> On Thu, 20 Apr 2023, Naresh Solanki wrote:
>>
>>> Hi Lee,
>>>
>>> On 20-04-2023 07:24 pm, Lee Jones wrote:
>>>> On Thu, 20 Apr 2023, Naresh Solanki wrote:
>>>>
>>>>> Hi Lee,
>>>>>
>>>>> On 20-04-2023 05:20 pm, Lee Jones wrote:
>>>>>> On Mon, 17 Apr 2023, Naresh Solanki wrote:
>>>>>>
>>>>>>> From: Patrick Rudolph <patrick.rudolph@9elements.com>
>>>>>>>
>>>>>>> max597x is hot swap controller with indicator LED support.
>>>>>>> This driver uses DT property to configure led during boot time &
>>>>>>> also provide the LED control in sysfs.
>>>>>>>
>>>>>>> DTS example:
>>>>>>>        i2c {
>>>>>>>            #address-cells = <1>;
>>>>>>>            #size-cells = <0>;
>>>>>>>            regulator@3a {
>>>>>>>                compatible = "maxim,max5978";
>>>>>>>                reg = <0x3a>;
>>>>>>>                vss1-supply = <&p3v3>;
>>>>>>>
>>>>>>>                regulators {
>>>>>>>                    sw0_ref_0: sw0 {
>>>>>>>                        shunt-resistor-micro-ohms = <12000>;
>>>>>>>                    };
>>>>>>>                };
>>>>>>>
>>>>>>>                leds {
>>>>>>>                    #address-cells = <1>;
>>>>>>>                    #size-cells = <0>;
>>>>>>>                    led@0 {
>>>>>>>                        reg = <0>;
>>>>>>>                        label = "ssd0:green";
>>>>>>>                        default-state = "on";
>>>>>>>                    };
>>>>>>>                    led@1 {
>>>>>>>                        reg = <1>;
>>>>>>>                        label = "ssd1:green";
>>>>>>>                        default-state = "on";
>>>>>>>                    };
>>>>>>>                };
>>>>>>>            };
>>>>>>>        };
>>>>>>
>>>>>> Where is the DT binding document for this?
>>> https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/tree/Documentation/devicetree/bindings/mfd/maxim,max5970.yaml?h=for-mfd-next
>>
>> You need to update it.  It is different to the one you supplied here.
> Ack.
>>
>>>>>>> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
>>>>>>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>>>>>>> ...
>>>>>>> Changes in V5:
>>>>>>> - Update commit message
>>>>>>> - Fix comments
>>>>>>> - Add necessary new line
>>>>>>> Changes in V4:
>>>>>>> - Remove unwanted preinitialise
>>>>>>> - Remove unneeded line breaks
>>>>>>> - Fix variable name to avoid confusion
>>>>>>> - Update module description to mention LED driver.
>>>>>>> Changes in V3:
>>>>>>> - Remove of_node_put as its handled by for loop
>>>>>>> - Print error if an LED fails to register.
>>>>>>> - Update driver name in Kconfig description
>>>>>>> - Remove unneeded variable assignment
>>>>>>> - Use devm_led_classdev_register to reget led
>>>>>>> Changes in V2:
>>>>>>> - Fix regmap update
>>>>>>> - Remove devm_kfree
>>>>>>> - Remove default-state
>>>>>>> - Add example dts in commit message
>>>>>>> - Fix whitespace in Kconfig
>>>>>>> - Fix comment
>>>>>>> ---
>>>>>>>     drivers/leds/Kconfig        |  11 ++++
>>>>>>>     drivers/leds/Makefile       |   1 +
>>>>>>>     drivers/leds/leds-max597x.c | 115 
>>>>>>> ++++++++++++++++++++++++++++++++++++
>>>>>>>     3 files changed, 127 insertions(+)
>>>>>>>     create mode 100644 drivers/leds/leds-max597x.c
>>
>> [...]
>>
>>>>>> +    led_node = of_get_child_by_name(np, "leds");
>>>>>>> +    if (!led_node)
>>>>>>> +        return -ENODEV;
>>>>
>>>> It's odd for a device to be referring to itself as the "child".
>>> As this is leaf driver, LED specific info is present in "leds" node 
>>> in DT.
>>
>> I'm aware of the architecture.
>>
>> If you give the LEDs driver it's own compatible you don't need to keep
>> doing this self->parent->child level-jumping craziness to obtain
>> resources.
>  From my understanding, it is preferable to have only one compatible per 
> chip(in this case MFD driver), and the leaf driver can leverage it 
> unless it is not serving the purpose/breaks something.
> I think this is acceptable as long as it doesn't creates any 
> issue/breaks anything.
I just wanted to kindly follow up and check if we are aligned with the 
approach. And kindly let me know if you have any concerns regarding this.

Thank you very much for your time and I look forward to hearing back 
from you soon :)
>>
> 
> 
> Regards,
> Naresh