From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Shuah Khan <shuahkh@osg.samsung.com>,
rpurdie@rpsys.net, pavel@ucw.cz, keescook@chromium.org,
shuah@kernel.org
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] leds: ledtrig-transient: Add SPDX license identifiers
Date: Thu, 11 Jan 2018 21:31:15 +0100 [thread overview]
Message-ID: <faaec698-d655-b2fd-e5ab-959fe9b3cd33@gmail.com> (raw)
In-Reply-To: <20180110224205.21926-1-shuahkh@osg.samsung.com>
Hi Shuah,
Thanks for the update.
On 01/10/2018 11:42 PM, Shuah Khan wrote:
> Replace GPL license statements with SPDX GPL-2.0 license identifiers
> and and correct the module license to GPLv2.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> Changes since v1:
> - Changed comment format and updated the entire block to match the
> comment format based on Jacek's review.
>
> drivers/leds/trigger/ledtrig-transient.c | 33 +++++++++++++-------------------
> 1 file changed, 13 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/leds/trigger/ledtrig-transient.c b/drivers/leds/trigger/ledtrig-transient.c
> index 7acce64b692a..9d1769073562 100644
> --- a/drivers/leds/trigger/ledtrig-transient.c
> +++ b/drivers/leds/trigger/ledtrig-transient.c
> @@ -1,22 +1,15 @@
> -/*
> - * LED Kernel Transient Trigger
> - *
> - * Copyright (C) 2012 Shuah Khan <shuahkhan@gmail.com>
> - *
> - * Based on Richard Purdie's ledtrig-timer.c and Atsushi Nemoto's
> - * ledtrig-heartbeat.c
> - * Design and use-case input from Jonas Bonn <jonas@southpole.se> and
> - * Neil Brown <neilb@suse.de>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> - */
> -/*
> - * Transient trigger allows one shot timer activation. Please refer to
> - * Documentation/leds/ledtrig-transient.txt for details
> -*/
> +// SPDX-License-Identifier: GPL-2.0
> +//
> +// LED Kernel Transient Trigger
> +//
> +// Transient trigger allows one shot timer activation. Please refer to
> +// Documentation/leds/ledtrig-transient.txt for details
> +// Copyright (C) 2012 Shuah Khan <shuahkhan@gmail.com>
> +//
> +// Based on Richard Purdie's ledtrig-timer.c and Atsushi Nemoto's
> +// ledtrig-heartbeat.c
> +// Design and use-case input from Jonas Bonn <jonas@southpole.se> and
> +// Neil Brown <neilb@suse.de>
>
> #include <linux/module.h>
> #include <linux/kernel.h>
> @@ -238,4 +231,4 @@ module_exit(transient_trig_exit);
>
> MODULE_AUTHOR("Shuah Khan <shuahkhan@gmail.com>");
> MODULE_DESCRIPTION("Transient LED trigger");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
>
Applied.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2018-01-11 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 22:42 [PATCH v2] leds: ledtrig-transient: Add SPDX license identifiers Shuah Khan
2018-01-11 20:31 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faaec698-d655-b2fd-e5ab-959fe9b3cd33@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).