From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EDFBC77B70 for ; Mon, 17 Apr 2023 09:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbjDQJm2 (ORCPT ); Mon, 17 Apr 2023 05:42:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230370AbjDQJmH (ORCPT ); Mon, 17 Apr 2023 05:42:07 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2D995267 for ; Mon, 17 Apr 2023 02:41:08 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id v9so30271551pjk.0 for ; Mon, 17 Apr 2023 02:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1681724434; x=1684316434; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FUcfly+k+twv5TfjaViZgJr1WMXFSTMq+Wmw06BPNrs=; b=NS5CXlhiUAguOyuMGYUowciRddHrxIdDs060zDhmUIXEVINK+W/oxAjbixPJ65gd0J erQBG8KUM0LSyZEl58wSqQPkrWG1oW73d61ISHmD2sJ79wg4vaMNup6+ojDS1rvMYLRh YjuSUkGBDLx/oSzPTUHzfITIEc4LmPIy6/kqtdlbHqbSfUFNRA3lPT3e3P9Z6b8UxlzO zMxvq9ziasKiqfJ1dS6xnB8xVD2IfeK5CpfGE5t9a6SUUuSr1aXYx8Gd0ZNvYQSzciHr +AXeOWVkLj72QGluprZy/BuFZ8nG7sjvJdHTaGKEVUdmCVr/dy7LtfFxIlHwG48yuU9G +Aow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681724434; x=1684316434; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FUcfly+k+twv5TfjaViZgJr1WMXFSTMq+Wmw06BPNrs=; b=WTzNfIpO2+HIbA5DIdV/RqQQjFivQKUMyAcOCYYd56m6LTHu+FcB5IhLdRCrY0a2Zy q4Kw0teKnRc25Ntp/sxLrg8QBTXh6thMo3FMuRxxd7LriMpoFyz9M2v5Ix96hGoyNMbm UujWYduYA4ztYayTMwGi3tDg12EHu8qslxrah0mlq/TZi3AUMobvY/+F5Hr7BLflFLF/ jKBjF3mRIJUH19gmX9sygDmbYXPUD6fRFVga9KNNjxNBA/Oyw/xJOrJdvwFqOwJKSGzD C1ctqEAPD6cMnYnxnDK0o+I6t9IQVvFGb1YixtSQyZ3Ymztv6RLJXAc5ruh5ba6tD6SL U4XQ== X-Gm-Message-State: AAQBX9eMyc6l8Gk4YrproFWniijpaKBkUJg3nW/LZ33d05uzUosifDAK w2aac0xE86MHanauAx8o//R0QQ== X-Google-Smtp-Source: AKy350arw8nWD9noplIjKGTttkk5WJxVqrqoAR5Y0o3lgIAl7LPGYXQ8vB9d99nZO+f8ESaKsHUtmw== X-Received: by 2002:a05:6a20:160e:b0:ef:511:d6fe with SMTP id l14-20020a056a20160e00b000ef0511d6femr7572558pzj.9.1681724433924; Mon, 17 Apr 2023 02:40:33 -0700 (PDT) Received: from ?IPV6:2405:201:d02f:d855:461d:14be:2cce:b776? ([2405:201:d02f:d855:461d:14be:2cce:b776]) by smtp.gmail.com with ESMTPSA id e6-20020aa78246000000b0062e024b5584sm7206126pfn.34.2023.04.17.02.40.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 02:40:33 -0700 (PDT) Message-ID: Date: Mon, 17 Apr 2023 15:10:31 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4] leds: max597x: Add support for max597x To: Pavel Machek Cc: Lee Jones , Patrick Rudolph , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org References: <20230413102624.3561299-1-Naresh.Solanki@9elements.com> Content-Language: en-US From: Naresh Solanki In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi Pavel, On 13-04-2023 04:43 pm, Pavel Machek wrote: > Hi! > >> From: Patrick Rudolph >> >> max597x is hot swap controller with indicator LED support. >> This driver uses DT property to configure led during boot time & >> also provide the LED control in sysfs. >> >> DTS example: >> i2c { >> #address-cells = <1>; >> #size-cells = <0>; >> regulator@3a { >> compatible = "maxim,max5978"; >> reg = <0x3a>; >> vss1-supply = <&p3v3>; >> >> regulators { >> sw0_ref_0: sw0 { >> shunt-resistor-micro-ohms = <12000>; >> }; >> }; >> >> leds { >> #address-cells = <1>; >> #size-cells = <0>; >> led@0 { >> reg = <0>; >> label = "led0"; >> default-state = "on"; >> }; >> led@1 { >> reg = <1>; >> label = "led1"; >> default-state = "on"; >> }; >> }; >> }; >> }; >> > > Yeah, well, dts bindings need to be properly documented, and example > goes to the binding, right? Yes. > > Plus, we should have better names than led0/led1. Something like > hdd0:green:something, based on what the LED does and what are you hot > swapping. See/modify Documentation/leds/well-known-leds.txt . Yeah sure. > > >> +static int max597x_led_set_brightness(struct led_classdev *cdev, >> + enum led_brightness brightness) >> +{ >> + struct max597x_led *ddata = ldev_to_maxled(cdev); >> + int ret, val; >> + >> + if (!ddata->regmap) >> + return -ENODEV; >> + >> + /* Set/Clear corresponding bit for given led index */ > > "/clear". Ack. > >> + val = !brightness ? BIT(ddata->index) : 0; >> + ret = regmap_update_bits(ddata->regmap, MAX5970_REG_LED_FLASH, BIT(ddata->index), val); >> + if (ret < 0) >> + dev_err(cdev->dev, "failed to set brightness %d", ret); > > '\n"'. Ack > >> + ddata->cdev.brightness_set_blocking = max597x_led_set_brightness; >> + ddata->cdev.default_trigger = "none"; > > So what do these leds normally do? Should they be registered with > common function to handle default triggers etc? Not sure if I understand your question right. In my use case in server motherboards, they are use to indicate presence of power for individual PCIe NVME connectors. Turning the LED on/off is handled by another application based on some conditions. > >> + ddata->index = reg; >> + ddata->regmap = regmap; >> + ret = devm_led_classdev_register(dev, &ddata->cdev); >> + if (ret) >> + dev_err(dev, "Error initializing LED %s", ddata->cdev.name); > > '\n"'. Ack > >> +module_platform_driver(max597x_led_driver); >> +MODULE_AUTHOR("Patrick Rudolph "); >> +MODULE_DESCRIPTION("MAX5970_hot-swap controller LED driver"); > > "MAX5970 hot-swap"? max5970 is primarily a hotswap controller & it also had indication led support. > >> +MODULE_LICENSE("GPL"); >> >> base-commit: 11e572d06c23d61683e20a98bd16f550ef17ac65 >> prerequisite-patch-id: 456044abe991b2ff3b521d337825432789d71b29 > > ?? Send prerequisites in the series? Will fix in v5. > > BR, > Pavel Regards, Naresh