From: sashiko-bot@kernel.org
To: "Flavio Amieiro" <flavio@amieiro.net>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH v2 1/2] leds: is31f132xx: Add support for is31fl3206
Date: Tue, 13 Oct 2026 09:58:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-169407@kernel.org> (raw)
In-Reply-To: <20261013-add-is31fl3206-support-v2-1-ca0d2bf5783f@amieiro.net>
> This chip has a different layout for the LED Control Register when
> compared to the other variants. This register contains the enable bit
> (in the highest nibble) but also the current control.
>
> According to the datasheet, a value of 010000 (0x10) in the register
> enables an LED with the output current set to maximum.
>
> This commit adds support for this IC following the previous limitation
> of the other variants: all LEDs are enabled and set with maximum
> current, letting brightness be controlled by the PWM registers.
>
> Signed-off-by: Flavio Amieiro <flavio@amieiro.net>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-add-is31fl3206-support-v2-0-ca0d2bf5783f@amieiro.net?part=1
next prev parent reply other threads:[~2026-10-13 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 9:43 [PATCH v2 0/2] leds: Add support for the is31fl3206 LED driver Flavio Amieiro
2026-10-13 9:43 ` [PATCH v2 1/2] leds: is31f132xx: Add support for is31fl3206 Flavio Amieiro
2026-10-13 9:58 ` sashiko-bot [this message]
2026-10-13 9:43 ` [PATCH v2 2/2] dt-bindings: leds: Add issi,is31fl3206 to leds-is31fl32xx Flavio Amieiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-169407@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=flavio@amieiro.net \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox