Re: [PATCH v11 5/7] leds: Add driver for ASUS Transformer LEDs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] leds: Commit message prefix violates naming convention
- [Low] mfd: Driver-specific header placed in global include/linux/mfd/
--

commit 6dfd67b7a2e641ea71f3bcae79bf5a863c4f809d
Author: Michał Mirosław <mirq-linux@rere.qmqm.pl>

leds: Add driver for ASUS Transformer LEDs

This commit adds a driver for the charging indicator LEDs on the Asus
Transformer pad and dock. It registers amber and green LEDs using the
asus-transformer-ec MFD core.

> leds: Add driver for ASUS Transformer LEDs

[Severity: Low]
This isn't a bug, but does the commit subject omit the mandatory driver
name segment? The LED subsystem guidelines recommend the commit message
prefix to follow the format "leds: <Driver>: <Capitalized description>".

Could this be updated to something like "leds: asus-transformer-ec: Add
driver for ASUS Transformer LEDs" for better git history categorization?

> diff --git a/drivers/leds/leds-asus-transformer-ec.c b/drivers/leds/leds-asus-transformer-ec.c
> index 0000000000000..1b129247ea6c6
> --- /dev/null
> +++ b/drivers/leds/leds-asus-transformer-ec.c
> @@ -0,0 +1,125 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +#include <linux/err.h>
> +#include <linux/leds.h>
> +#include <linux/mfd/asus-transformer-ec.h>

[Severity: Low]
Is this driver-specific header globally exposed in include/linux/mfd/?

The MFD subsystem guidelines suggest keeping driver-specific header files
local to drivers/mfd/ if they are only used by the parent and its immediate
children, rather than placing them in the global include/linux/mfd/
directory.

Would it be possible to move asus-transformer-ec.h out of the global
include path?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013173504.451391-1-clamor95@gmail.com?part=5