From: sashiko-bot@kernel.org
To: "Jiale Yao" <yaojiale02@163.com>, linux-leds@vger.kernel.org
Cc: lee@kernel.org
Subject: Re: [PATCH 2/2] leds: cr0014114: queue recount work on freezable workqueue
Date: Fri, 16 Oct 2026 10:15:34 +0000 [thread overview]
Message-ID: <sashiko-outbox-174136@kernel.org> (raw)
In-Reply-To: <20261016100435.2581303-3-yaojiale02@163.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] leds: Guideline violation: Uncapitalized commit message description
--
commit 2ba0c5cc8cf57633496ac16ae32b61b6ab9d6609
Author: Jiale Yao <yaojiale02@163.com>
leds: cr0014114: queue recount work on freezable workqueue
This commit changes the recount delayed work to run on the
system_freezable_wq instead of the standard workqueue. This defers hardware
access from the workaround until the devices have fully resumed.
> leds: cr0014114: queue recount work on freezable workqueue
[Severity: Low]
This isn't a bug, but the LED subsystem guidelines require the commit
message description after the subsystem prefix to be capitalized. Should
"queue" be changed to "Queue" here to match standard conventions and assist
with Git history categorization?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261016100435.2581303-1-yaojiale02@163.com?part=2
prev parent reply other threads:[~2026-10-16 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 10:04 [PATCH 0/2] leds: freeze delayed hardware access during suspend Jiale Yao
2026-10-16 10:04 ` [PATCH 1/2] leds: tps6131x: queue torch refresh work on freezable workqueue Jiale Yao
2026-10-16 10:17 ` sashiko-bot
2026-10-16 10:04 ` [PATCH 2/2] leds: cr0014114: queue recount " Jiale Yao
2026-10-16 10:15 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-174136@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yaojiale02@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox