Re: [PATCH v3] leds: is31fl32xx: Fix NULL pointer dereference when binding via I2C ID table

[sashiko-bot@kernel.org]

> If the device binds via the I2C ID table (e.g. sysfs new_device, a
> software node, or a firmware node without a matching compatible),
> device_get_match_data() in is31fl32xx_probe() returns NULL, since only
> the OF match table carries the chip definition. is31fl32xx_parse_dt()
> then dereferences cdef->output_frequency_setting_reg and
> is31fl32xx_parse_child_dt() dereferences cdef->channels, causing a
> kernel oops.
> 
> Populate .driver_data in is31fl32xx_id with the same chip definitions
> as the OF table and use i2c_get_match_data(), which falls back to the
> I2C ID table when no firmware match data is available. Every entry
> now carries match data, so cdef can no longer be NULL.
> 
> Drop the comment above the ID table, as the table is now used for
> matching data as well.
> 
> Fixes: 2779f4724b2f ("leds: various: use device_get_match_data")
> Cc: stable@vger.kernel.org
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018225036.12000-1-rosenp@gmail.com?part=1