From: sashiko-bot@kernel.org
To: "Dmitry Ilvokhin" <d@ilvokhin.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH 10/10] checkpatch: suggest nonnull attribute conversion
Date: Wed, 28 Oct 2026 08:27:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-187627@kernel.org> (raw)
In-Reply-To: <bc2cd702455e58feb777cdb230e3ba4f7e1db60f.1793027261.git.d@ilvokhin.com>
> The kernel provides the __nonnull_args() macro as the preferred form for
> marking pointer arguments as non-NULL. Add a check suggesting the macro
> over the raw __attribute__((nonnull)) spelling, consistent with the
> existing attribute conversion suggestions.
>
> Examples:
>
> WARNING: Prefer __nonnull_args(1, 2) over __attribute__((nonnull(1, 2)))
> #11: FILE: drivers/soc/aspeed/aspeed-lpc-snoop.c:230:
> +__attribute__((nonnull(1, 2)))
>
> WARNING: Prefer __nonnull_args() over __attribute__((nonnull))
> #11: FILE: drivers/soc/aspeed/aspeed-lpc-snoop.c:283:
> +__attribute__((nonnull))
>
> Signed-off-by: Dmitry Ilvokhin <d@ilvokhin.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1793027261.git.d@ilvokhin.com?part=10
next prev parent reply other threads:[~2026-10-28 8:27 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 8:19 [PATCH 00/10] treewide: switch to __nonnull_args() macro Dmitry Ilvokhin
2026-10-28 8:19 ` [PATCH 01/10] docs: xforms_lists: support __nonnull_args() Dmitry Ilvokhin
2026-10-28 8:27 ` sashiko-bot
2026-10-28 8:19 ` [PATCH 02/10] string: Switch to __nonnull_args() macro Dmitry Ilvokhin
2026-10-28 8:27 ` sashiko-bot
2026-10-28 9:48 ` Andy Shevchenko
2026-10-28 8:19 ` [PATCH 03/10] lib/list_sort: " Dmitry Ilvokhin
2026-10-28 8:27 ` sashiko-bot
2026-10-28 9:47 ` Andy Shevchenko
2026-10-28 8:19 ` [PATCH 04/10] xarray: switch " Dmitry Ilvokhin
2026-10-28 8:27 ` sashiko-bot
2026-10-28 8:19 ` [PATCH 05/10] drm/i915: " Dmitry Ilvokhin
2026-10-28 8:27 ` sashiko-bot
2026-10-28 9:49 ` Andy Shevchenko
2026-10-28 11:33 ` Jani Nikula
2026-10-28 11:44 ` Andi Shyti
2026-10-29 8:43 ` Jani Nikula
2026-10-28 8:19 ` [PATCH 06/10] drm/amdgpu: " Dmitry Ilvokhin
2026-10-28 8:27 ` sashiko-bot
2026-10-28 8:19 ` [PATCH 07/10] drm/gem: Switch " Dmitry Ilvokhin
2026-10-28 8:27 ` sashiko-bot
2026-10-28 11:44 ` Andi Shyti
2026-10-29 7:32 ` Thomas Zimmermann
2026-10-28 8:19 ` [PATCH 08/10] leds: pwm: " Dmitry Ilvokhin
2026-10-28 8:27 ` sashiko-bot
2026-10-28 9:49 ` Andy Shevchenko
2026-10-28 8:19 ` [PATCH 09/10] soc: aspeed: lpc-snoop: " Dmitry Ilvokhin
2026-10-28 8:27 ` sashiko-bot
2026-10-28 8:19 ` [PATCH 10/10] checkpatch: suggest nonnull attribute conversion Dmitry Ilvokhin
2026-10-28 8:27 ` sashiko-bot [this message]
2026-10-28 16:11 ` Joe Perches
2026-10-28 20:44 ` [PATCH 00/10] treewide: switch to __nonnull_args() macro Randy Dunlap
2026-10-29 6:16 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-187627@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=d@ilvokhin.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox