From: sashiko-bot@kernel.org
To: "Yige Jiang" <yigejiang86@gmail.com>, linux-leds@vger.kernel.org
Cc: lee@kernel.org
Subject: Re: [PATCH v2] leds: pwm-multicolor: Manage the multi-led node reference
Date: Fri, 30 Oct 2026 02:09:18 +0000 [thread overview]
Message-ID: <sashiko-outbox-190167@kernel.org> (raw)
In-Reply-To: <20261030020521.9399-1-yigejiang86@gmail.com>
> led_pwm_mc_probe() leaks the multi-led node reference on successful
> probe and if the final PWM update fails. LED registration borrows
> the node, so it must remain valid until the LED is unregistered.
>
> Register a managed put action before LED registration. Reverse devres
> order then unregisters the LED before releasing the node on unbind
> or probe failure. Drop the manual error-path put and return directly
> on probe errors, leaving the reference cleanup to devres.
>
> Fixes: 9fa2762110dd ("leds: Add PWM multicolor driver")
> Assisted-by: LLM
> Signed-off-by: Yige Jiang <yigejiang86@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261030020521.9399-1-yigejiang86@gmail.com?part=1
prev parent reply other threads:[~2026-10-30 2:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 2:05 [PATCH v2] leds: pwm-multicolor: Manage the multi-led node reference Yige Jiang
2026-10-30 2:09 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-190167@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yigejiang86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox