From: sashiko-bot@kernel.org
To: "Arnd Bergmann" <arnd@kernel.org>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH] leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency
Date: Wed, 04 Nov 2026 14:27:40 +0000 [thread overview]
Message-ID: <sashiko-outbox-197430@kernel.org> (raw)
In-Reply-To: <20261104142415.676757-1-arnd@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] leds: asus-aura-scsi: commit subject description is not capitalized
--
commit e05e6430efbaa79461253555061a0b258c6afe65
Author: Arnd Bergmann <arnd@arndb.de>
leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency
This commit adds a Kconfig dependency on SCSI_DH to LEDS_ASUS_AURA_SCSI in
drivers/leds/rgb/Kconfig so the driver does not fail to link when
scsi_register_device_handler is unavailable.
> leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency
>
> Without the device handler support, the driver fails to link:
>
> ERROR: modpost: drivers/leds/rgb/leds-asus-aura-scsi.ko: symbol 'scsi_register_device_handler' undefined!
>
> Add a Kconfig dependency to only show the symbol if it can
> be enabled.
>
> Fixes: 6173959c7d4d ("leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
[Severity: Low]
This isn't a bug, but in the commit subject for this LEDS_ASUS_AURA_SCSI
change in drivers/leds/rgb/Kconfig, should the description after the
"leds: asus-aura-scsi: " prefix start with a capital letter to match the LED
subsystem convention (i.e., "leds: asus-aura-scsi: Add CONFIG_SCSI_DH
dependency")?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261104142415.676757-1-arnd@kernel.org?part=1
next prev parent reply other threads:[~2026-11-04 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 13:20 [PATCH] leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency Arnd Bergmann
2026-11-04 14:27 ` sashiko-bot [this message]
2026-11-04 14:41 ` Liang Haowen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-197430@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=arnd@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox